Sign upLogin

killbill/killbill-client-ruby

View on GitHub
Star
lib/killbill_client/models/invoice.rb

Summary

Maintainability
D
2 days
Test Coverage

File invoice.rb has 331 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module KillBillClient
  module Model
    class Invoice < InvoiceAttributes

      include KillBillClient::Model::CustomFieldHelper
Severity: Minor
Found in lib/killbill_client/models/invoice.rb - About 3 hrs to fix

    Class Invoice has 26 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Invoice < InvoiceAttributes

      include KillBillClient::Model::CustomFieldHelper
      include KillBillClient::Model::TagHelper
      include KillBillClient::Model::AuditLogWithHistoryHelper
    Severity: Minor
    Found in lib/killbill_client/models/invoice.rb - About 3 hrs to fix

      Method change_plan_dry_run has 11 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def change_plan_dry_run(account_id, bundle_id, subscription_id, target_date, product_name, product_category, billing_period, price_list_name,
                                effective_date, billing_policy, options = {})
      Severity: Major
      Found in lib/killbill_client/models/invoice.rb - About 1 hr to fix

        Method trigger_invoice_dry_run has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                def trigger_invoice_dry_run(account_id, target_date, upcoming_invoice_target_date, plugin_property = [], user = nil, reason = nil, comment = nil, options = {})
        Severity: Major
        Found in lib/killbill_client/models/invoice.rb - About 1 hr to fix

          Method create_subscription_dry_run has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  def create_subscription_dry_run(account_id, bundle_id, target_date, product_name, product_category,
                                        billing_period, price_list_name,  options = {})
          Severity: Major
          Found in lib/killbill_client/models/invoice.rb - About 1 hr to fix

            Method cancel_subscription_dry_run has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    def cancel_subscription_dry_run(account_id, bundle_id, subscription_id, target_date,
                                        effective_date, billing_policy,  options = {})
            Severity: Major
            Found in lib/killbill_client/models/invoice.rb - About 50 mins to fix

              Method upload_invoice_translation has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      def upload_invoice_translation(invoice_translation, locale, delete_if_exists, user = nil, reason = nil, comment = nil, options = {})
              Severity: Major
              Found in lib/killbill_client/models/invoice.rb - About 50 mins to fix

                Method create_migration_invoice has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        def create_migration_invoice(account_id, invoices, target_date, user = nil, reason = nil, comment = nil, options = {})
                Severity: Major
                Found in lib/killbill_client/models/invoice.rb - About 50 mins to fix

                  Method upload_catalog_translation has 7 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          def upload_catalog_translation(catalog_translation, locale, delete_if_exists, user = nil, reason = nil, comment = nil, options = {})
                  Severity: Major
                  Found in lib/killbill_client/models/invoice.rb - About 50 mins to fix

                    Method upload_invoice_template has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            def upload_invoice_template(invoice_template, is_manual_pay, delete_if_exists, user = nil, reason = nil, comment = nil, options = {})
                    Severity: Major
                    Found in lib/killbill_client/models/invoice.rb - About 50 mins to fix

                      Method trigger_invoice_group_run has 7 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              def trigger_invoice_group_run(account_id, target_date = nil, plugin_property = nil, user = nil, reason = nil, comment = nil, options = {})
                      Severity: Major
                      Found in lib/killbill_client/models/invoice.rb - About 50 mins to fix

                        Method trigger_invoice_dry_run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                                def trigger_invoice_dry_run(account_id, target_date, upcoming_invoice_target_date, plugin_property = [], user = nil, reason = nil, comment = nil, options = {})

          dry_run = InvoiceDryRunAttributes.new
          dry_run.dry_run_type = upcoming_invoice_target_date ? 'UPCOMING_INVOICE' : 'TARGET_DATE'
                        Severity: Minor
                        Found in lib/killbill_client/models/invoice.rb - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method trigger_invoice has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                def trigger_invoice(account_id, target_date, user = nil, reason = nil, comment = nil, options = {})
                        Severity: Minor
                        Found in lib/killbill_client/models/invoice.rb - About 45 mins to fix

                          Method retrieve_invoice_group has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                  def retrieve_invoice_group(account_id, group_id, with_children_items = false, audit = "NONE", options = {})
                          Severity: Minor
                          Found in lib/killbill_client/models/invoice.rb - About 35 mins to fix

                            Method retrieve_payments_for_invoice has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    def retrieve_payments_for_invoice(invoice_id, with_plugin_info = false, with_attempts = false, audit = "NONE", options = {})
                            Severity: Minor
                            Found in lib/killbill_client/models/invoice.rb - About 35 mins to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      def upload_catalog_translation(catalog_translation, locale, delete_if_exists, user = nil, reason = nil, comment = nil, options = {})

          require_multi_tenant_options!(options, "Uploading a catalog translation is only supported in multi-tenant mode")

          params                  = {}
                              Severity: Major
                              Found in lib/killbill_client/models/invoice.rb and 1 other location - About 1 hr to fix
                              lib/killbill_client/models/invoice.rb on lines 257..275

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 48.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      def upload_invoice_translation(invoice_translation, locale, delete_if_exists, user = nil, reason = nil, comment = nil, options = {})

          require_multi_tenant_options!(options, "Uploading a invoice translation is only supported in multi-tenant mode")
                              Severity: Major
                              Found in lib/killbill_client/models/invoice.rb and 1 other location - About 1 hr to fix
                              lib/killbill_client/models/invoice.rb on lines 290..307

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 48.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                    def void(user = nil, reason = nil, comment = nil, options = {})

        self.class.put "#{Invoice::KILLBILL_API_INVOICES_PREFIX}/#{invoice_id}/voidInvoice",
                       nil,
                       {},
                              Severity: Minor
                              Found in lib/killbill_client/models/invoice.rb and 1 other location - About 30 mins to fix
                              lib/killbill_client/models/invoice.rb on lines 360..369

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 32.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                    def commit(user = nil, reason = nil, comment = nil, options = {})

        self.class.put "#{Invoice::KILLBILL_API_INVOICES_PREFIX}/#{invoice_id}/commitInvoice",
                       nil,
                       {},
                              Severity: Minor
                              Found in lib/killbill_client/models/invoice.rb and 1 other location - About 30 mins to fix
                              lib/killbill_client/models/invoice.rb on lines 373..382

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 32.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 4 locations. Consider refactoring.
                              Open

                                    def trigger_email_notifications(user = nil, reason = nil, comment = nil, options = {})
        self.class.post "#{KILLBILL_API_INVOICES_PREFIX}/#{invoice_id}/emailNotifications",
                        {},
                        {},
                        {
                              Severity: Minor
                              Found in lib/killbill_client/models/invoice.rb and 3 other locations - About 25 mins to fix
                              lib/killbill_client/models/account.rb on lines 148..156
                              lib/killbill_client/models/account.rb on lines 374..382
                              lib/killbill_client/models/subscription.rb on lines 212..221

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 31.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status