Sign upLogin

killbill/killbill-client-ruby

View on GitHub
Star
lib/killbill_client/models/invoice_item.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method create has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def create(auto_commit = false, user = nil, reason = nil, comment = nil, options = {})
Severity: Minor
Found in lib/killbill_client/models/invoice_item.rb - About 35 mins to fix

    Method add_tags_from_definition_ids has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def add_tags_from_definition_ids(tag_definition_ids, user, reason, comment, options)
    Severity: Minor
    Found in lib/killbill_client/models/invoice_item.rb - About 35 mins to fix

      Method create_tax_item has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def create_tax_item(auto_commit = false, user = nil, reason = nil, comment = nil, options = {})
      Severity: Minor
      Found in lib/killbill_client/models/invoice_item.rb - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def create_tax_item(auto_commit = false, user = nil, reason = nil, comment = nil, options = {})
        created_tax_item = self.class.post "#{Invoice::KILLBILL_API_INVOICES_PREFIX}/taxes/#{account_id}",
                                               [to_hash].to_json,
                                               {:autoCommit => auto_commit},
                                               {
        Severity: Minor
        Found in lib/killbill_client/models/invoice_item.rb and 1 other location - About 50 mins to fix
        lib/killbill_client/models/invoice_item.rb on lines 45..54

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def create(auto_commit = false, user = nil, reason = nil, comment = nil, options = {})
        created_invoice_item = self.class.post "#{Invoice::KILLBILL_API_INVOICES_PREFIX}/charges/#{account_id}",
                                               [to_hash].to_json,
                                               {:autoCommit => auto_commit},
                                               {
        Severity: Minor
        Found in lib/killbill_client/models/invoice_item.rb and 1 other location - About 50 mins to fix
        lib/killbill_client/models/invoice_item.rb on lines 89..98

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status