Sign upLogin

killbill/killbill-client-ruby

View on GitHub
Star
lib/killbill_client/models/nodes_info.rb

Summary

Maintainability
D
1 day
Test Coverage

Method create_proc_condition_for_wait_for_plugin_command_completion has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

        def create_proc_condition_for_wait_for_plugin_command_completion(options, plugin_key, plugin_version, state=nil, is_negate=false)
          proc_condition = Proc.new {
            node_infos = KillBillClient::Model::NodesInfo.nodes_info(options)

            res = true
Severity: Minor
Found in lib/killbill_client/models/nodes_info.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method trigger_node_command_wait_for_plugin_command_completion has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def trigger_node_command_wait_for_plugin_command_completion(node_command_type, plugin_key, plugin_version, plugin_props, local_node_only, user, reason, comment, options, timeout_sec, sleep_sec, &proc_condition)
Severity: Major
Found in lib/killbill_client/models/nodes_info.rb - About 1 hr to fix

    Method install_plugin has 10 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def install_plugin(plugin_key, plugin_version=nil, plugin_props=[], local_node_only=false, user = nil, reason = nil, comment = nil, options = {}, timeout_sec=30, sleep_sec=1)
    Severity: Major
    Found in lib/killbill_client/models/nodes_info.rb - About 1 hr to fix

      Method stop_plugin has 10 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def stop_plugin(plugin_key, plugin_version=nil, plugin_props=[], local_node_only=false, user = nil, reason = nil, comment = nil, options = {}, timeout_sec=15, sleep_sec=1)
      Severity: Major
      Found in lib/killbill_client/models/nodes_info.rb - About 1 hr to fix

        Method uninstall_plugin has 10 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                def uninstall_plugin(plugin_key, plugin_version=nil, plugin_props=[], local_node_only=false, user = nil, reason = nil, comment = nil, options = {}, timeout_sec=15, sleep_sec=1)
        Severity: Major
        Found in lib/killbill_client/models/nodes_info.rb - About 1 hr to fix

          Method start_plugin has 10 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  def start_plugin(plugin_key, plugin_version=nil, plugin_props=[], local_node_only=false, user = nil, reason = nil, comment = nil, options = {}, timeout_sec=15, sleep_sec=1)
          Severity: Major
          Found in lib/killbill_client/models/nodes_info.rb - About 1 hr to fix

            Method wait_for_plugin_command_completion has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                    def wait_for_plugin_command_completion(command, plugin, timeout_sec, sleep_sec)
          if KillBillClient.logger
            KillBillClient.log :info, "NodesInfo waiting for command='%s', plugin='%s'" % [command, plugin]
          end
          begin
            Severity: Minor
            Found in lib/killbill_client/models/nodes_info.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method trigger_node_command has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    def trigger_node_command(node_command, local_node_only, user = nil, reason = nil, comment = nil, options = {})
            Severity: Minor
            Found in lib/killbill_client/models/nodes_info.rb - About 45 mins to fix

              Method create_proc_condition_for_wait_for_plugin_command_completion has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      def create_proc_condition_for_wait_for_plugin_command_completion(options, plugin_key, plugin_version, state=nil, is_negate=false)
              Severity: Minor
              Found in lib/killbill_client/models/nodes_info.rb - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        def stop_plugin(plugin_key, plugin_version=nil, plugin_props=[], local_node_only=false, user = nil, reason = nil, comment = nil, options = {}, timeout_sec=15, sleep_sec=1)

          proc_condition = create_proc_condition_for_wait_for_plugin_command_completion(options, plugin_key, plugin_version, "STOPPED")

          trigger_node_command_wait_for_plugin_command_completion(:STOP_PLUGIN, plugin_key, plugin_version, plugin_props, local_node_only, user, reason, comment, options, timeout_sec, sleep_sec, &proc_condition)
                Severity: Minor
                Found in lib/killbill_client/models/nodes_info.rb and 1 other location - About 45 mins to fix
                lib/killbill_client/models/nodes_info.rb on lines 20..24

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 40.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        def start_plugin(plugin_key, plugin_version=nil, plugin_props=[], local_node_only=false, user = nil, reason = nil, comment = nil, options = {}, timeout_sec=15, sleep_sec=1)

          proc_condition = create_proc_condition_for_wait_for_plugin_command_completion(options, plugin_key, plugin_version, "RUNNING")

          trigger_node_command_wait_for_plugin_command_completion(:START_PLUGIN, plugin_key, plugin_version, plugin_props, local_node_only, user, reason, comment, options, timeout_sec, sleep_sec, &proc_condition)
                Severity: Minor
                Found in lib/killbill_client/models/nodes_info.rb and 1 other location - About 45 mins to fix
                lib/killbill_client/models/nodes_info.rb on lines 27..31

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 40.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status