Sign upLogin

killbill/killbill-client-ruby

View on GitHub
Star
lib/killbill_client/models/resource.rb

Summary

Maintainability
C
1 day
Test Coverage

Method instantiate_record_from_json has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

        def instantiate_record_from_json(resource_class, data)
          record = resource_class.send :new

          kb_ancestors = resource_class.ancestors.select { |ancestor| !@@attribute_names[ancestor.name].nil? }
          data.each do |name, value|
Severity: Minor
Found in lib/killbill_client/models/resource.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Resource has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Resource

      attr_reader :clazz,
                  :etag,
                  :session_id,
Severity: Minor
Found in lib/killbill_client/models/resource.rb - About 2 hrs to fix

    Method from_response has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

            def from_response(resource_class, response)
          case response['Content-Type']
            when nil
              response.body
            when %r{application/pdf}
    Severity: Minor
    Found in lib/killbill_client/models/resource.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method from_response has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def from_response(resource_class, response)
          case response['Content-Type']
            when nil
              response.body
            when %r{application/pdf}
    Severity: Minor
    Found in lib/killbill_client/models/resource.rb - About 1 hr to fix

      Method instantiate_record_from_json has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def instantiate_record_from_json(resource_class, data)
          record = resource_class.send :new

          kb_ancestors = resource_class.ancestors.select { |ancestor| !@@attribute_names[ancestor.name].nil? }
          data.each do |name, value|
      Severity: Minor
      Found in lib/killbill_client/models/resource.rb - About 1 hr to fix

        Method from_json has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

                def from_json(resource_class, json)
          # e.g. DELETE
          return nil if json.nil? or json.size == 0
          data = JSON.parse json
        Severity: Minor
        Found in lib/killbill_client/models/resource.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method delete has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                def delete(uri, body = nil, params = {}, options = {}, clazz = self)
        Severity: Minor
        Found in lib/killbill_client/models/resource.rb - About 35 mins to fix

          Method put has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  def put(uri, body = nil, params = {}, options = {}, clazz = self)
          Severity: Minor
          Found in lib/killbill_client/models/resource.rb - About 35 mins to fix

            Method post has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    def post(uri, body = nil, params = {}, options = {}, clazz = self)
            Severity: Minor
            Found in lib/killbill_client/models/resource.rb - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      def has_many(attr_name, type = nil)
          send("attr_accessor", attr_name.to_sym)

          #add it to attribute_names
          @@attribute_names[self.name] ||= {}
              Severity: Minor
              Found in lib/killbill_client/models/resource.rb and 1 other location - About 15 mins to fix
              lib/killbill_client/models/resource.rb on lines 195..200

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 26.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      def has_one(attr_name, type = nil)
          send("attr_accessor", attr_name.to_sym)

          #add it to attribute_names
          @@attribute_names[self.name] ||= {}
              Severity: Minor
              Found in lib/killbill_client/models/resource.rb and 1 other location - About 15 mins to fix
              lib/killbill_client/models/resource.rb on lines 187..192

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 26.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status