Sign upLogin

killbill/killbill-client-ruby

View on GitHub
Star
lib/killbill_client/models/subscription.rb

Summary

Maintainability
C
1 day
Test Coverage

Method create_entitlement_with_add_on has 10 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def create_entitlement_with_add_on(entitlements, entitlement_date, billing_date, migrated = false, rename_key_if_exists_and_unused = true, call_completion_sec = nil, user = nil, reason = nil, comment = nil, options = {})
Severity: Major
Found in lib/killbill_client/models/subscription.rb - About 1 hr to fix

    Method set_blocking_state has 10 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def set_blocking_state(state_name, service, is_block_change, is_block_entitlement, is_block_billing, requested_date = nil, user = nil, reason = nil, comment = nil, options = {})
    Severity: Major
    Found in lib/killbill_client/models/subscription.rb - About 1 hr to fix

      Method change_plan has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def change_plan(input, user = nil, reason = nil, comment = nil,
                      requested_date = nil, billing_policy = nil, target_phase_type = nil, call_completion = false, options = {})
      Severity: Major
      Found in lib/killbill_client/models/subscription.rb - About 1 hr to fix

        Method cancel has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def cancel(user = nil, reason = nil, comment = nil, requested_date = nil, entitlementPolicy = nil, billing_policy = nil, use_requested_date_for_billing = nil, options = {})
        Severity: Major
        Found in lib/killbill_client/models/subscription.rb - About 1 hr to fix

          Method create has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                def create(user = nil, reason = nil, comment = nil, requested_date = nil, call_completion = false, options = {})
          Severity: Minor
          Found in lib/killbill_client/models/subscription.rb - About 45 mins to fix

            Method cancel has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                  def cancel(user = nil, reason = nil, comment = nil, requested_date = nil, entitlementPolicy = nil, billing_policy = nil, use_requested_date_for_billing = nil, options = {})
        params                              = {}
        params[:requestedDate]              = requested_date unless requested_date.nil?
        params[:billingPolicy]              = billing_policy unless billing_policy.nil?
        params[:entitlementPolicy]          = entitlementPolicy unless entitlementPolicy.nil?
            Severity: Minor
            Found in lib/killbill_client/models/subscription.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method update_quantity has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                  def update_quantity(user = nil, reason = nil, comment = nil, effective_from_date = nil, force_new_quantity_with_past_effective_date = nil, options = {})
            Severity: Minor
            Found in lib/killbill_client/models/subscription.rb - About 45 mins to fix

              Method update_bcd has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                    def update_bcd(user = nil, reason = nil, comment = nil, effective_from_date = nil, force_past_effective_date = nil, options = {})
              Severity: Minor
              Found in lib/killbill_client/models/subscription.rb - About 45 mins to fix

                Method create_entitlement_with_add_on has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                      def create_entitlement_with_add_on(entitlements, entitlement_date, billing_date, migrated = false, rename_key_if_exists_and_unused = true, call_completion_sec = nil, user = nil, reason = nil, comment = nil, options = {})
        params = {}
        params[:entitlementDate] = entitlement_date if entitlement_date
        params[:billingDate] = billing_date if billing_date
        params[:migrated] = migrated
                Severity: Minor
                Found in lib/killbill_client/models/subscription.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      def update_quantity(user = nil, reason = nil, comment = nil, effective_from_date = nil, force_new_quantity_with_past_effective_date = nil, options = {})
        params                  = {}
        params[:effectiveFromDate] = effective_from_date unless effective_from_date.nil?
        params[:forceNewQuantityWithPastEffectiveDate] = force_new_quantity_with_past_effective_date unless force_new_quantity_with_past_effective_date.nil?
                Severity: Major
                Found in lib/killbill_client/models/subscription.rb and 1 other location - About 1 hr to fix
                lib/killbill_client/models/subscription.rb on lines 144..157

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 53.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      def update_bcd(user = nil, reason = nil, comment = nil, effective_from_date = nil, force_past_effective_date = nil, options = {})

        params                  = {}
        params[:effectiveFromDate] = effective_from_date unless effective_from_date.nil?
        params[:forceNewBcdWithPastEffectiveDate] = force_past_effective_date unless force_past_effective_date.nil?
                Severity: Major
                Found in lib/killbill_client/models/subscription.rb and 1 other location - About 1 hr to fix
                lib/killbill_client/models/subscription.rb on lines 227..239

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 53.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                      def undo_change_plan(user = nil, reason = nil, comment = nil, options = {})

        self.class.put "#{KILLBILL_API_ENTITLEMENT_PREFIX}/#{subscription_id}/undoChangePlan",
                       {},
                       {},
                Severity: Minor
                Found in lib/killbill_client/models/subscription.rb and 3 other locations - About 25 mins to fix
                lib/killbill_client/models/account.rb on lines 148..156
                lib/killbill_client/models/account.rb on lines 374..382
                lib/killbill_client/models/invoice.rb on lines 397..405

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 31.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status