Sign upLogin

kindrid/gotest

View on GitHub
Star

Showing 10 of 10 total issues

Function BeSortedByField has 54 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func BeSortedByField(actual interface{}, args ...interface{}) (fail string) {
    json, path, field, isDescending, fail := argsForBesortedByField(actual, args...)
    if fail != "" {
        return
    }
Severity: Minor
Found in should/json.go - About 1 hr to fix

    Function checkCamelcaseKeys has 6 return statements (exceeds 4 allowed).
    Open

    func checkCamelcaseKeys(j *gabs.Container, ignores map[string]bool) (fail string) {
    // if j is an Object with keys, check each of keys and children
    children, notObjectErr := j.ChildrenMap()
    if notObjectErr == nil {
        for k, v := range children {
    Severity: Major
    Found in should/json.go - About 40 mins to fix

      Function argsForBesortedByField has 6 return statements (exceeds 4 allowed).
      Open

      func argsForBesortedByField(
    actual interface{}, args ...interface{}) (
    parsedActual StructureExplorer,
    elementPath, fieldName string, isDescending bool,
    fail string,
      Severity: Major
      Found in should/json.go - About 40 mins to fix

        Function BeJsonapiError has 5 return statements (exceeds 4 allowed).
        Open

        func BeJsonapiError(actual interface{}, expected ...interface{}) (fail string) {
    usage := "BeJsonapiError expects a single string argument and passes if that argument parses as a JSON:API error response."
    if actual == nil {
        return usage
    }
        Severity: Major
        Found in should/jsonapi.go - About 35 mins to fix

          Function NotJSONAPIError has 5 return statements (exceeds 4 allowed).
          Open

          func NotJSONAPIError(actual interface{}, expected ...interface{}) (fail string) {
    usage := "BeJSONAPIArray expects a single string argument and passes if that argument parses as a JSONAPI multi-object array."
    if actual == nil {
        return usage
    }
          Severity: Major
          Found in should/jsonapi.go - About 35 mins to fix

            Function MatchHTTPStatusCode has 5 return statements (exceeds 4 allowed).
            Open

            func MatchHTTPStatusCode(actual interface{}, expected ...interface{}) (fail string) {
    if msg := exactly(1, expected); msg != Ok {
        return msg
    }
    eStatus, ok := expected[0].(int)
            Severity: Major
            Found in should/http.go - About 35 mins to fix

              Function BeSortedByField has 5 return statements (exceeds 4 allowed).
              Open

              func BeSortedByField(actual interface{}, args ...interface{}) (fail string) {
    json, path, field, isDescending, fail := argsForBesortedByField(actual, args...)
    if fail != "" {
        return
    }
              Severity: Major
              Found in should/json.go - About 35 mins to fix

                Method RESTHarness.RunRequest has 5 return statements (exceeds 4 allowed).
                Open

                func (har *RESTHarness) RunRequest(requestID string, body string, params ...string) (result *RESTExchange) {
    var expected, actual *http.Response
    // Grab information from the Describer (API specification)
    result = &RESTExchange{}
    result.Request, expected, result.Err = har.API.GetRequest(requestID, body, params...)
                Severity: Major
                Found in should/rest.go - About 35 mins to fix

                  Function argsForCountTests has 5 return statements (exceeds 4 allowed).
                  Open

                  func argsForCountTests(
    actual interface{}, args ...interface{}) (
    parsedActual StructureExplorer,
    elementPath string,
    count int,
                  Severity: Major
                  Found in should/json.go - About 35 mins to fix

                    Function checkCamelcaseKeys has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                    Open

                    func checkCamelcaseKeys(j *gabs.Container, ignores map[string]bool) (fail string) {
    // if j is an Object with keys, check each of keys and children
    children, notObjectErr := j.ChildrenMap()
    if notObjectErr == nil {
        for k, v := range children {
                    Severity: Minor
                    Found in should/json.go - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language