kindrid/gotest

View on GitHub
should/json.go

Summary

Maintainability
B
4 hrs
Test Coverage

Function BeSortedByField has 54 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func BeSortedByField(actual interface{}, args ...interface{}) (fail string) {
    json, path, field, isDescending, fail := argsForBesortedByField(actual, args...)
    if fail != "" {
        return
    }
Severity: Minor
Found in should/json.go - About 1 hr to fix

    Function checkCamelcaseKeys has 6 return statements (exceeds 4 allowed).
    Open

    func checkCamelcaseKeys(j *gabs.Container, ignores map[string]bool) (fail string) {
        // if j is an Object with keys, check each of keys and children
        children, notObjectErr := j.ChildrenMap()
        if notObjectErr == nil {
            for k, v := range children {
    Severity: Major
    Found in should/json.go - About 40 mins to fix

      Function argsForBesortedByField has 6 return statements (exceeds 4 allowed).
      Open

      func argsForBesortedByField(
          actual interface{}, args ...interface{}) (
          parsedActual StructureExplorer,
          elementPath, fieldName string, isDescending bool,
          fail string,
      Severity: Major
      Found in should/json.go - About 40 mins to fix

        Function argsForCountTests has 5 return statements (exceeds 4 allowed).
        Open

        func argsForCountTests(
            actual interface{}, args ...interface{}) (
            parsedActual StructureExplorer,
            elementPath string,
            count int,
        Severity: Major
        Found in should/json.go - About 35 mins to fix

          Function BeSortedByField has 5 return statements (exceeds 4 allowed).
          Open

          func BeSortedByField(actual interface{}, args ...interface{}) (fail string) {
              json, path, field, isDescending, fail := argsForBesortedByField(actual, args...)
              if fail != "" {
                  return
              }
          Severity: Major
          Found in should/json.go - About 35 mins to fix

            Function checkCamelcaseKeys has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
            Open

            func checkCamelcaseKeys(j *gabs.Container, ignores map[string]bool) (fail string) {
                // if j is an Object with keys, check each of keys and children
                children, notObjectErr := j.ChildrenMap()
                if notObjectErr == nil {
                    for k, v := range children {
            Severity: Minor
            Found in should/json.go - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status