Sign upLogin

kisenka/svg-sprite-loader

View on GitHub
Star

Showing 21 of 21 total issues

Function apply has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  apply(compiler) {
    this.rules = getMatchedRule(compiler);

    const path = this.rules.outputPath ? this.rules.outputPath : this.rules.publicPath;
    this.filenamePrefix = path
Severity: Major
Found in lib/plugin.js - About 3 hrs to fix

    Function exports has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = (compiler) => {
  const rawRules = compiler.options.module.rules;
  let spriteLoader = null;
  for (const rawRule of rawRules) {
    if (isSpriteLoader(rawRule)) {
    Severity: Minor
    Found in lib/utils/get-matched-rule-5.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function loader has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function loader(content) {
  if (this.cacheable) {
    this.cacheable();
  }
    Severity: Minor
    Found in lib/loader.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function loader has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function loader(content) {
  if (this.cacheable) {
    this.cacheable();
  }
    Severity: Major
    Found in lib/loader.js - About 2 hrs to fix

      Function getModuleChunk has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      function getModuleChunk(module, modules, moduleGraph, chunkGraph) {
  let chunks;

  if (chunkGraph && chunkGraph.getOrderedModuleChunksIterable) {
    chunks = Array.from(chunkGraph.getOrderedModuleChunksIterable(module));
      Severity: Minor
      Found in lib/utils/get-module-chunk.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function isModuleShouldBeExtracted has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      function isModuleShouldBeExtracted(module, moduleGraph) {
  const { request, loaders } = module;
  let rule = null;

  let issuer;
      Severity: Minor
      Found in lib/utils/is-module-should-be-extracted.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function exports has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = () => {
  const config = {
    files: [
      { pattern: 'lib/**/*.js' },
      { pattern: 'test/_*.js', instrument: false },
      Severity: Minor
      Found in wallaby.config.js - About 1 hr to fix

        Function create has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          create() {
    const { symbols, spriteModules, allModules, rule, moduleGraph, chunkGraph } = this;

    const data = symbols.reduce((acc, symbol) => {
      const resource = symbol.request.file;
        Severity: Minor
        Found in lib/utils/mapped-list.js - About 1 hr to fix

          Function create has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            create() {
    const { symbols, spriteModules, allModules, rule, moduleGraph, chunkGraph } = this;

    const data = symbols.reduce((acc, symbol) => {
      const resource = symbol.request.file;
          Severity: Minor
          Found in lib/utils/mapped-list.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if (warnings.length > 0) {
      msgs.push(`BUILD EXAMPLES WARNINGS\n${warnings.map(w => w.message).join('\n\n')}`);
    }
          Severity: Major
          Found in scripts/build-examples-dll.js and 1 other location - About 1 hr to fix
          scripts/build-examples-dll.js on lines 27..29

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if (errors.length > 0) {
      msgs.push(`BUILD EXAMPLES ERRORS\n${errors.map(e => e.message).join('\n\n')}`);
    }
          Severity: Major
          Found in scripts/build-examples-dll.js and 1 other location - About 1 hr to fix
          scripts/build-examples-dll.js on lines 23..25

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function runtimeGenerator has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function runtimeGenerator(params) {
  const { symbol, config, context, loaderContext } = params;
  const { extract, esModule, spriteModule, symbolModule, runtimeCompat, publicPath } = config;
  let runtime;
          Severity: Minor
          Found in lib/runtime-generator.js - About 1 hr to fix

            Function exports has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            module.exports = (config) => {
  config.set({
    // base path that will be used to resolve all patterns (eg. files, exclude)
    basePath: '',
            Severity: Minor
            Found in karma.conf.js - About 1 hr to fix

              Function runtimeGenerator has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              function runtimeGenerator(params) {
  const { symbol, config, context, loaderContext } = params;
  const { extract, esModule, spriteModule, symbolModule, runtimeCompat, publicPath } = config;
  let runtime;
              Severity: Minor
              Found in lib/runtime-generator.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function normalizeRule has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              function normalizeRule(rule) {
  if (!rule) {
    throw new Error('Rule should be string or object');
  }
              Severity: Minor
              Found in lib/utils/normalize-rule.js - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getLoaderOptions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              function getLoaderOptions(loaderPath, rule) {
  let multiRuleProp;

  if (isWebpack1) {
    multiRuleProp = 'loaders';
              Severity: Minor
              Found in lib/utils/get-loader-options.js - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function configurator has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              module.exports = function configurator({ config, context, target }) {
  const module = context._module;
  const compiler = context._compiler;
  const compilation = context._compilation;
  const compilerName = compiler.name;
              Severity: Minor
              Found in lib/configurator.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getAllModules has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              function getAllModules(compilation) {
  let modules = Array.from(compilation.modules);

  // Look up in child compilations
  if (compilation.children.length > 0) {
              Severity: Minor
              Found in lib/utils/get-all-modules.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              TODO found
              Open

                // TODO optimize MappedList instantiation in each hook
              Severity: Minor
              Found in lib/plugin.js by fixme

              TODO found
              Open

              // TODO refactor this smelly code!
              Severity: Minor
              Found in lib/utils/mapped-list.js by fixme
              Severity
              Category
              Status
              Source
              Language