Sign upLogin

kishikawakatsumi/xcjobs

View on GitHub
Star
lib/xcjobs/coverage.rb

Summary

Maintainability
C
1 day
Test Coverage

Method collect has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

      def collect(base_dir)
        report = {}
        report['repo_token'] = repo_token if repo_token
        report['service_name'] = service_name if service_name
        report['service_job_id'] = service_job_id if service_job_id
Severity: Minor
Found in lib/xcjobs/coverage.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method collect has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def collect(base_dir)
        report = {}
        report['repo_token'] = repo_token if repo_token
        report['service_name'] = service_name if service_name
        report['service_job_id'] = service_job_id if service_job_id
Severity: Major
Found in lib/xcjobs/coverage.rb - About 2 hrs to fix

    Method is_excluded_path has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def is_excluded_path(filepath)
        if filepath.start_with?('..')
          return true
        end
        @excludes.each do |exclude|
    Severity: Minor
    Found in lib/xcjobs/coverage.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

              return true
    Severity: Major
    Found in lib/xcjobs/coverage.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                return false
      Severity: Major
      Found in lib/xcjobs/coverage.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status