kitdim/java-project

View on GitHub

Showing 5 of 5 total issues

Method create has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static void create(Context ctx) throws SQLException {
        String input = ctx.formParamAsClass("url", String.class)
                .get()
                .trim()
                .toLowerCase();
Severity: Minor
Found in app/src/main/java/hexlet/code/controller/UrlController.java - About 1 hr to fix

    Method createCheck has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static void createCheck(Context ctx) throws SQLException {
            Long urlId = ctx.pathParamAsClass("id", Long.class).get();
            Url url = UrlsRepository.find(urlId)
                    .orElseThrow(() -> new NotFoundResponse("Entity with id = " + urlId + " not found"));
            try {
    Severity: Minor
    Found in app/src/main/java/hexlet/code/controller/UrlCheckController.java - About 1 hr to fix

      Method getEntities has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static Optional<List<UrlCheck>> getEntities(Long searchId) throws SQLException {
              var sql = "SELECT * FROM url_checks where url_id = ?";
              try (var conn = dataSource.getConnection();
                   var stmt = conn.prepareStatement(sql)) {
                  stmt.setLong(1, searchId);
      Severity: Minor
      Found in app/src/main/java/hexlet/code/repository/UrlsCheckRepository.java - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        var urlCheck = UrlCheck.builder()
                                .id(id)
                                .urlId(urlId)
                                .statusCode(statusCode)
                                .h1(h1)
        app/src/main/java/hexlet/code/repository/UrlsCheckRepository.java on lines 57..65

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        var urlCheck = UrlCheck.builder()
                                .id(id)
                                .urlId(urlId)
                                .statusCode(statusCode)
                                .h1(h1)
        app/src/main/java/hexlet/code/repository/UrlsCheckRepository.java on lines 86..94

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language