kiwitcms/Kiwi

View on GitHub

Showing 209 of 346 total issues

Cyclomatic complexity is too high in function update. (15)
Open

@permissions_required("testruns.change_testexecution")
@rpc_method(name="TestExecution.update")
def update(execution_id, values, **kwargs):
    """
    .. function:: RPC TestExecution.update(execution_id, values)
Severity: Minor
Found in tcms/rpc/api/testexecution.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  if (filterBy === 'is_automated' || filterBy === 'priority' || filterBy === 'category') {
    const query = { executions__run: runId }
    if (filterBy === 'is_automated') {
      query[filterBy] = filterValue
    } else if (filterBy === 'priority') {
Severity: Major
Found in tcms/testruns/static/testruns/js/get.js and 1 other location - About 3 hrs to fix
tcms/testplans/static/testplans/js/get.js on lines 686..699

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  if (filterBy === 'component' || filterBy === 'tag') {
    const query = { plan: planId }
    query[`${filterBy}__name__icontains`] = filterValue

    jsonRPC('TestCase.filter', query, function (filtered) {
Severity: Major
Found in tcms/testplans/static/testplans/js/get.js and 1 other location - About 3 hrs to fix
tcms/testruns/static/testruns/js/get.js on lines 231..250

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getTestCaseExpandArea has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getTestCaseExpandArea (row, testCase, permissions) {
  markdown2HTML(testCase.text, row.find('.js-test-case-expand-text'))
  if (testCase.notes.trim().length > 0) {
    row.find('.js-test-case-expand-notes').html(testCase.notes)
  }
Severity: Major
Found in tcms/testplans/static/testplans/js/get.js - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def populate(self, product_id=None):
            if product_id:
                self.fields["category"].queryset = Category.objects.filter(
                    product_id=product_id
                )
    Severity: Major
    Found in tcms/testcases/forms.py and 1 other location - About 3 hrs to fix
    tcms/testruns/forms.py on lines 74..79

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def populate(self, product_id=None):
            if product_id:
                self.fields["version"].queryset = Version.objects.filter(
                    product__pk=product_id
                )
    Severity: Major
    Found in tcms/testruns/forms.py and 1 other location - About 3 hrs to fix
    tcms/testcases/forms.py on lines 128..133

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function drawChart has 73 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function drawChart () {
      const query = {}
    
      const productIds = $('#id_product').val()
      if (productIds.length) {
    Severity: Major
    Found in tcms/telemetry/static/telemetry/js/testing/execution-trends.js - About 2 hrs to fix

      File types.py has 285 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      """
          This module implements Kiwi TCMS interface to external issue tracking systems.
          Refer to each implementor class for integration specifics!
      """
      
      
      Severity: Minor
      Found in tcms/issuetracker/types.py - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        Severity: Major
        Found in tcms/rpc/api/testcasestatus.py and 1 other location - About 2 hrs to fix
        tcms/rpc/api/category.py on lines 0..24

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        Severity: Major
        Found in tcms/rpc/api/category.py and 1 other location - About 2 hrs to fix
        tcms/rpc/api/testcasestatus.py on lines 0..24

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function renderAdditionalInformation has 69 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function renderAdditionalInformation (testRunId, execution) {
          let linksQuery = { execution__run: testRunId }
          let casesQuery = { executions__run: testRunId }
          let componentQ = { cases__executions__run: testRunId }
          let tagsQ = { case__executions__run: testRunId }
        Severity: Major
        Found in tcms/testruns/static/testruns/js/get.js - About 2 hrs to fix

          File utils.js has 281 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          /*
              Used to update a select when something else changes.
          */
          function updateSelect (data, selector, idAttr, valueAttr, groupAttr) {
            const _selectTag = $(selector)[0]
          Severity: Minor
          Found in tcms/static/js/utils.js - About 2 hrs to fix

            Function drawTable has 68 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function drawTable () {
              if (table) {
                table.destroy()
            
                $('table > thead > tr > th:not(.header)').remove()
            Severity: Major
            Found in tcms/telemetry/static/telemetry/js/testing/status-matrix.js - About 2 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  def populate(self, product_id):
                      if product_id:
                          self.fields["product_version"].queryset = Version.objects.filter(
                              product_id=product_id
                          )
              Severity: Major
              Found in tcms/testplans/forms.py and 1 other location - About 2 hrs to fix
              tcms/testplans/forms.py on lines 78..84

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 58.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  def populate(self, product_pk):
                      if product_pk:
                          self.fields["version"].queryset = Version.objects.filter(
                              product_id=product_pk
                          )
              Severity: Major
              Found in tcms/testplans/forms.py and 1 other location - About 2 hrs to fix
              tcms/testplans/forms.py on lines 18..24

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 58.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Cyclomatic complexity is too high in function create_permissions. (11)
              Open

              def create_permissions(
                  app_config,
                  verbosity=2,
                  interactive=True,
                  using=DEFAULT_DB_ALIAS,
              Severity: Minor
              Found in tcms/bugs/management.py by radon

              Cyclomatic Complexity

              Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

              Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

              Construct Effect on CC Reasoning
              if +1 An if statement is a single decision.
              elif +1 The elif statement adds another decision.
              else +0 The else statement does not cause a new decision. The decision is at the if.
              for +1 There is a decision at the start of the loop.
              while +1 There is a decision at the while statement.
              except +1 Each except branch adds a new conditional path of execution.
              finally +0 The finally block is unconditionally executed.
              with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
              assert +1 The assert statement internally roughly equals a conditional statement.
              Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
              Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

              Source: http://radon.readthedocs.org/en/latest/intro.html

              Cyclomatic complexity is too high in method tree_view_html. (11)
              Open

                  def tree_view_html(self):
                      """
                      Returns nested tree structure represented as Patterfly TreeView!
                      Relies on the fact that tree nodes are returned in DFS
                      order!
              Severity: Minor
              Found in tcms/testplans/models.py by radon

              Cyclomatic Complexity

              Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

              Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

              Construct Effect on CC Reasoning
              if +1 An if statement is a single decision.
              elif +1 The elif statement adds another decision.
              else +0 The else statement does not cause a new decision. The decision is at the if.
              for +1 There is a decision at the start of the loop.
              while +1 There is a decision at the while statement.
              except +1 Each except branch adds a new conditional path of execution.
              finally +0 The finally block is unconditionally executed.
              with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
              assert +1 The assert statement internally roughly equals a conditional statement.
              Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
              Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

              Source: http://radon.readthedocs.org/en/latest/intro.html

              File testplan.py has 275 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              # -*- coding: utf-8 -*-
              
              from django.forms.models import model_to_dict
              from modernrpc.core import REQUEST_KEY, rpc_method
              
              
              Severity: Minor
              Found in tcms/rpc/api/testplan.py - About 2 hrs to fix

                Function attachEvents has 65 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function attachEvents (testPlanId, permissions) {
                  treeViewBind('#testcases-list')
                
                  if (permissions['perm-change-testcase']) {
                    // update default tester
                Severity: Major
                Found in tcms/testplans/static/testplans/js/get.js - About 2 hrs to fix

                  File testrun.py has 275 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  # -*- coding: utf-8 -*-
                  from django.forms.models import model_to_dict
                  from modernrpc.core import REQUEST_KEY, rpc_method
                  
                  from tcms.core.utils import form_errors_to_list
                  Severity: Minor
                  Found in tcms/rpc/api/testrun.py - About 2 hrs to fix
                    Severity
                    Category
                    Status
                    Source
                    Language