kiwitcms/Kiwi

View on GitHub

Showing 243 of 379 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    tags.forEach(function (element) {
      if (tagsPerCase[element.case] === undefined) {
        tagsPerCase[element.case] = []
      }

Severity: Major
Found in tcms/testcases/static/testcases/js/search.js and 2 other locations - About 3 hrs to fix
tcms/testcases/static/testcases/js/search.js on lines 24..33
tcms/testplans/static/testplans/js/search.js on lines 10..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 114.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    tags.forEach(function (element) {
      if (tagsPerPlan[element.plan] === undefined) {
        tagsPerPlan[element.plan] = []
      }

Severity: Major
Found in tcms/testplans/static/testplans/js/search.js and 2 other locations - About 3 hrs to fix
tcms/testcases/static/testcases/js/search.js on lines 10..19
tcms/testcases/static/testcases/js/search.js on lines 24..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 114.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function renderAdditionalInformation has 90 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function renderAdditionalInformation (testRunId, execution) {
  let linksQuery = { execution__run: testRunId }
  let casesQuery = { executions__run: testRunId }
  let componentQ = { cases__executions__run: testRunId }
  let tagsQ = { case__executions__run: testRunId }
Severity: Major
Found in tcms/testruns/static/testruns/js/get.js - About 3 hrs to fix

    File testrun.py has 315 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    # -*- coding: utf-8 -*-
    from django.forms.models import model_to_dict
    from modernrpc.core import REQUEST_KEY, rpc_method
    
    from tcms.core.utils import form_errors_to_list
    Severity: Minor
    Found in tcms/rpc/api/testrun.py - About 3 hrs to fix

      Function getExpandArea has 88 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function getExpandArea (testExecution) {
        const container = $(`.test-execution-${testExecution.id}`)
      
        container.find('.test-execution-information .run-date').html(testExecution.close_date || '-')
        container.find('.test-execution-information .build').html(testExecution.build__name)
      Severity: Major
      Found in tcms/testruns/static/testruns/js/get.js - About 3 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        @permissions_required("management.add_version")
        @rpc_method(name="Version.create")
        def create(values):
            """
            .. function:: RPC Version.create(values)
        Severity: Major
        Found in tcms/rpc/api/version.py and 1 other location - About 3 hrs to fix
        tcms/rpc/api/category.py on lines 32..53

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        @rpc_method(name="Product.create")
        @permissions_required("management.add_product")
        def create(values):
            """
            .. function:: RPC Product.create(values)
        Severity: Major
        Found in tcms/rpc/api/product.py and 2 other locations - About 3 hrs to fix
        tcms/rpc/api/classification.py on lines 30..51
        tcms/rpc/api/plantype.py on lines 17..37

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        @permissions_required("testcases.add_category")
        @rpc_method(name="Category.create")
        def create(values):
            """
            .. function:: RPC Category.create(values)
        Severity: Major
        Found in tcms/rpc/api/category.py and 1 other location - About 3 hrs to fix
        tcms/rpc/api/version.py on lines 38..64

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        @rpc_method(name="PlanType.create")
        @permissions_required("testplans.add_plantype")
        def create(values):
            """
            .. function:: RPC PlanType.create(values)
        Severity: Major
        Found in tcms/rpc/api/plantype.py and 2 other locations - About 3 hrs to fix
        tcms/rpc/api/classification.py on lines 30..51
        tcms/rpc/api/product.py on lines 17..38

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        @rpc_method(name="Classification.create")
        @permissions_required("management.add_classification")
        def create(values):
            """
            .. function:: RPC Classification.create(values)
        Severity: Major
        Found in tcms/rpc/api/classification.py and 2 other locations - About 3 hrs to fix
        tcms/rpc/api/plantype.py on lines 17..37
        tcms/rpc/api/product.py on lines 17..38

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Cyclomatic complexity is too high in function update. (15)
        Open

        @permissions_required("testruns.change_testexecution")
        @rpc_method(name="TestExecution.update")
        def update(execution_id, values, **kwargs):
            """
            .. function:: RPC TestExecution.update(execution_id, values)
        Severity: Minor
        Found in tcms/rpc/api/testexecution.py by radon

        Cyclomatic Complexity

        Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

        Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

        Construct Effect on CC Reasoning
        if +1 An if statement is a single decision.
        elif +1 The elif statement adds another decision.
        else +0 The else statement does not cause a new decision. The decision is at the if.
        for +1 There is a decision at the start of the loop.
        while +1 There is a decision at the while statement.
        except +1 Each except branch adds a new conditional path of execution.
        finally +0 The finally block is unconditionally executed.
        with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
        assert +1 The assert statement internally roughly equals a conditional statement.
        Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
        Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

        Source: http://radon.readthedocs.org/en/latest/intro.html

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          if (filterBy === 'is_automated' || filterBy === 'priority' || filterBy === 'category') {
            const query = { executions__run: runId }
            if (filterBy === 'is_automated') {
              query[filterBy] = filterValue
            } else if (filterBy === 'priority') {
        Severity: Major
        Found in tcms/testruns/static/testruns/js/get.js and 1 other location - About 3 hrs to fix
        tcms/testplans/static/testplans/js/get.js on lines 686..699

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          if (filterBy === 'component' || filterBy === 'tag') {
            const query = { plan: planId }
            query[`${filterBy}__name__icontains`] = filterValue
        
            jsonRPC('TestCase.filter', query, function (filtered) {
        Severity: Major
        Found in tcms/testplans/static/testplans/js/get.js and 1 other location - About 3 hrs to fix
        tcms/testruns/static/testruns/js/get.js on lines 233..252

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function getTestCaseExpandArea has 78 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function getTestCaseExpandArea (row, testCase, permissions) {
          markdown2HTML(testCase.text, row.find('.js-test-case-expand-text'))
          if (testCase.notes.trim().length > 0) {
            row.find('.js-test-case-expand-notes').html(testCase.notes)
          }
        Severity: Major
        Found in tcms/testplans/static/testplans/js/get.js - About 3 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def populate(self, product_id=None):
                  if product_id:
                      self.fields["category"].queryset = Category.objects.filter(
                          product_id=product_id
                      )
          Severity: Major
          Found in tcms/testcases/forms.py and 1 other location - About 3 hrs to fix
          tcms/testruns/forms.py on lines 88..93

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def populate(self, product_id=None):
                  if product_id:
                      self.fields["version"].queryset = Version.objects.filter(
                          product__pk=product_id
                      )
          Severity: Major
          Found in tcms/testruns/forms.py and 1 other location - About 3 hrs to fix
          tcms/testcases/forms.py on lines 109..114

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          File utils.js has 290 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          /*
              Used to update a select when something else changes.
          */
          function updateSelect (data, selector, idAttr, valueAttr, groupAttr) {
            const _selectTag = $(selector)[0]
          Severity: Minor
          Found in tcms/static/js/utils.js - About 2 hrs to fix

            Function drawChart has 73 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function drawChart () {
              const query = {}
            
              const productIds = $('#id_product').val()
              if (productIds.length) {
            Severity: Major
            Found in tcms/telemetry/static/telemetry/js/testing/execution-trends.js - About 2 hrs to fix

              File testexecution.py has 288 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              # -*- coding: utf-8 -*-
              
              from django.conf import settings
              from django.forms.models import model_to_dict
              from django.utils import timezone
              Severity: Minor
              Found in tcms/rpc/api/testexecution.py - About 2 hrs to fix

                File types.py has 286 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                """
                    This module implements Kiwi TCMS interface to external issue tracking systems.
                    Refer to each implementor class for integration specifics!
                """
                
                
                Severity: Minor
                Found in tcms/issuetracker/types.py - About 2 hrs to fix
                  Severity
                  Category
                  Status
                  Source
                  Language