src/Statement/Cond.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '31', column '19').
Open

        $el = new \ECL\ExpressionLanguage;
Severity: Minor
Found in src/Statement/Cond.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid variables with short names like $el. Configured minimum length is 3.
Open

        $el = new \ECL\ExpressionLanguage;
Severity: Minor
Found in src/Statement/Cond.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The variable $pos_case is not named in camelCase.
Open

    public function __construct($expr, $pos_case, $neg_case=null) {
        $this->expr = $expr;
        $this->pos_case = $pos_case;
        $this->neg_case = $neg_case;
    }
Severity: Minor
Found in src/Statement/Cond.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $neg_case is not named in camelCase.
Open

    public function __construct($expr, $pos_case, $neg_case=null) {
        $this->expr = $expr;
        $this->pos_case = $pos_case;
        $this->neg_case = $neg_case;
    }
Severity: Minor
Found in src/Statement/Cond.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status