Sign upLogin

kiyonori-matsumoto/tcl-ruby

View on GitHub
Star
lib/tcl/ruby/command.rb

Summary

Maintainability
C
1 day
Test Coverage

Method replace_commands has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

      def replace_commands(list)
        l = list.dup
        s = StringScanner.new(l)
        buffer = nil
        depth = 0
Severity: Minor
Found in lib/tcl/ruby/command.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method replace_variable has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

      def replace_variable(elem)
        elem.gsub!(/\$\{(.+?)\}|\$(\w+\([^\s)]+\))|\$(\w+)/) do |_|
          v = Regexp.last_match(1) || Regexp.last_match(2) ||
              Regexp.last_match(3)
          h = nil
Severity: Minor
Found in lib/tcl/ruby/command.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method command has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def command(cmds)
        ret = nil
        cmds.each do |arg|
          next if arg.empty?
          arg.replace(&method(:replace))
Severity: Minor
Found in lib/tcl/ruby/command.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method replace_commands has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def replace_commands(list)
        l = list.dup
        s = StringScanner.new(l)
        buffer = nil
        depth = 0
Severity: Minor
Found in lib/tcl/ruby/command.rb - About 1 hr to fix

Avoid deeply nested control flow statements.
Open

          elsif s.scan(/[^\[\]\\]+/m)
            buffer << s[0] if buffer
Severity: Major
Found in lib/tcl/ruby/command.rb - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

            if depth == 0
              l[pos, buffer.length] = parse(buffer[1..-2]).to_s
              s.string = l
              buffer = nil
            end
Severity: Major
Found in lib/tcl/ruby/command.rb - About 45 mins to fix

There are no issues that match your filters.

Category
Status