Sign upLogin

kj415j45/kjBot

View on GitHub
Star
module/osu/tools.php

Summary

Maintainability
A
1 hr
Test Coverage

Function praseMod has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Wontfix

function praseMod($mod){
    $list=NULL;
    if($mod & 1)$list['NF']=1;
    if($mod & 2)$list['EZ']=1;
    if($mod & 4)$list['TD']=1;
Severity: Minor
Found in module/osu/tools.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method drawScore has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

function drawScore($recent, $map, $u){
    Image::configure(array('driver' => 'imagick'));

    $here = __DIR__.'/';
    $exo2 = $here.'Exo2-Regular.ttf';
Severity: Minor
Found in module/osu/tools.php - About 1 hr to fix

    Method imageFont has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Wontfix

    function imageFont($file = 1, $size = 12, $color = '#000000', $align = 'left', $valign = 'buttom', $angle = 0){
    Severity: Minor
    Found in module/osu/tools.php - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function get_user_recent($k, $u, $m = OsuMode::std){
    $u=OsuUsernameEscape($u);
    $result = json_decode(file_get_contents("https://osu.ppy.sh/api/get_user_recent?k={$k}&u={$u}&m={$m}"), true)[0];
    if(NULL === $result){
        throw new \Exception('玩家最近没有成绩');
      Severity: Minor
      Found in module/osu/tools.php and 1 other location - About 55 mins to fix
      module/osu/tools.php on lines 133..140

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 98.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function get_user($k, $u, $m = OsuMode::std){
    $u=OsuUsernameEscape($u);
    $result = json_decode(file_get_contents("https://osu.ppy.sh/api/get_user?k={$k}&u={$u}&m={$m}"), true)[0];
    if(NULL === $result){
        throw new \Exception('无效的 osu! ID，请检查用户名是否正确（或者被 ban 了');
      Severity: Minor
      Found in module/osu/tools.php and 1 other location - About 55 mins to fix
      module/osu/tools.php on lines 115..122

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 98.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status