Sign upLogin

kleros/kleros-v2

View on GitHub
Star
subgraph/core/src/KlerosCore.ts

Summary

Maintainability
C
1 day
Test Coverage

Function handleNewPeriod has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function handleNewPeriod(event: NewPeriod): void {
  const disputeID = event.params._disputeID;
  const dispute = Dispute.load(disputeID.toString());
  if (!dispute) return;
  const court = Court.load(dispute.court);
Severity: Minor
Found in subgraph/core/src/KlerosCore.ts - About 2 hrs to fix

Function handleNewPeriod has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

export function handleNewPeriod(event: NewPeriod): void {
  const disputeID = event.params._disputeID;
  const dispute = Dispute.load(disputeID.toString());
  if (!dispute) return;
  const court = Court.load(dispute.court);
Severity: Minor
Found in subgraph/core/src/KlerosCore.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    for (let i = 0; i < dispute.jurors.entries.length; i++) {
      juror = ensureUser(dispute.jurors.entries[i].value.toString());
      juror.totalAppealingDisputes = juror.totalAppealingDisputes.minus(ONE);
      juror.save();
    }
Severity: Major
Found in subgraph/core/src/KlerosCore.ts and 1 other location - About 3 hrs to fix
subgraph/core/src/KlerosCore.ts on lines 114..118

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    for (let i = 0; i < dispute.jurors.entries.length; i++) {
      juror = ensureUser(dispute.jurors.entries[i].value.toString());
      juror.totalAppealingDisputes = juror.totalAppealingDisputes.plus(ONE);
      juror.save();
    }
Severity: Major
Found in subgraph/core/src/KlerosCore.ts and 1 other location - About 3 hrs to fix
subgraph/core/src/KlerosCore.ts on lines 99..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Expected a 'for-of' loop instead of a 'for' loop with this simple iteration
Open

    for (let i = 0; i < dispute.jurors.entries.length; i++) {
Severity: Minor
Found in subgraph/core/src/KlerosCore.ts by tslint

Rule: prefer-for-of

Recommends a 'for-of' loop over a standard 'for' loop if the index is only used to access the array being iterated.

Rationale

A for(... of ...) loop is easier to implement and read when the index is not needed.

Config

Not configurable.

Examples
"prefer-for-of": true

For more information see this page.

Use a conditional expression instead of assigning to 'dispute.periodDeadline' in multiple places.
Open

  if (newPeriod !== "execution") {
Severity: Minor
Found in subgraph/core/src/KlerosCore.ts by tslint

Rule: prefer-conditional-expression

Recommends to use a conditional expression instead of assigning to the same thing in each branch of an if statement.

Rationale

This reduces duplication and can eliminate an unnecessary variable declaration.

Config

If check-else-if is specified, the rule also checks nested if-else-if statements.

Examples
"prefer-conditional-expression": true
"prefer-conditional-expression": true,check-else-if
Schema
{
  "type": "string",
  "enum": [
    "check-else-if"
  ]
}

For more information see this page.

Expected a 'for-of' loop instead of a 'for' loop with this simple iteration
Open

    for (let i = 0; i < dispute.jurors.entries.length; i++) {
Severity: Minor
Found in subgraph/core/src/KlerosCore.ts by tslint

Rule: prefer-for-of

Recommends a 'for-of' loop over a standard 'for' loop if the index is only used to access the array being iterated.

Rationale

A for(... of ...) loop is easier to implement and read when the index is not needed.

Config

Not configurable.

Examples
"prefer-for-of": true

For more information see this page.

There are no issues that match your filters.

Category
Status