Sign upLogin

kleros/kleros-v2

View on GitHub
Star
web/src/pages/Cases/CaseDetails/MaintenanceButtons/index.tsx

Summary

Maintainability
A
3 hrs
Test Coverage

Function MaintenanceButtons has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const MaintenanceButtons: React.FC = () => {
  const { id } = useParams();
  const [isOpen, setIsOpen] = useState(false);
  const [displayRipple, setDisplayRipple] = useState(false);
Severity: Major
Found in web/src/pages/Cases/CaseDetails/MaintenanceButtons/index.tsx - About 2 hrs to fix

Similar blocks of code found in 6 locations. Consider refactoring.
Open

const PopupContainer = styled.div`
  display: flex;
  flex-direction: column;
  position: absolute;
  height: fit-content;
Severity: Major
Found in web/src/pages/Cases/CaseDetails/MaintenanceButtons/index.tsx and 5 other locations - About 1 hr to fix
web/src/components/HowItWorks.tsx on lines 6..26
web/src/components/Popup/MiniGuides/Onboarding/PnkLogoAndTitle.tsx on lines 27..37
web/src/layout/Header/navbar/Menu/Settings/General.tsx on lines 18..34
web/src/pages/Cases/CaseDetails/Voting/VotesDetails/index.tsx on lines 53..61
web/src/pages/Courts/StakeMaintenanceButton/index.tsx on lines 21..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Missing radix parameter
Open

          now > parseInt(dispute.lastPeriodChange) + parseInt(dispute.court.timesPerPeriod[period])) ||
Severity: Minor
Found in web/src/pages/Cases/CaseDetails/MaintenanceButtons/index.tsx by tslint

Rule: radix

Requires the radix parameter to be specified when calling parseInt.

Rationale

From MDN:

Always specify this parameter to eliminate reader confusion and to guarantee predictable behavior. Different implementations produce different results when a radix is not specified, usually defaulting the value to 10.

Config

Not configurable.

Examples
"radix": true

For more information see this page.

Missing radix parameter
Open

          now > parseInt(dispute.lastPeriodChange) + parseInt(dispute.court.timesPerPeriod[period])) ||
Severity: Minor
Found in web/src/pages/Cases/CaseDetails/MaintenanceButtons/index.tsx by tslint

Rule: radix

Requires the radix parameter to be specified when calling parseInt.

Rationale

From MDN:

Always specify this parameter to eliminate reader confusion and to guarantee predictable behavior. Different implementations produce different results when a radix is not specified, usually defaulting the value to 10.

Config

Not configurable.

Examples
"radix": true

For more information see this page.

There are no issues that match your filters.

Category
Status