Sign upLogin

kleros/kleros-v2

View on GitHub
Star
web/src/utils/jurorRewardConfig.ts

Summary

Maintainability
A
1 hr
Test Coverage

Function getFormattedRewards has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

export const getFormattedRewards = (data: any, pricesData: any) => {
  return rewards.map(({ token, coinId, getValue, getAmount }) => {
    const coinPrice = !isUndefined(pricesData) ? pricesData[CoinIds[token]]?.price : undefined;

    const totalReward = data && calculateTotalJurorReward(coinId, data);
Severity: Minor
Found in web/src/utils/jurorRewardConfig.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing radix parameter
Open

    .map((shift) => parseInt(coinId === 0 ? shift.pnkAmount : shift.ethAmount))
Severity: Minor
Found in web/src/utils/jurorRewardConfig.ts by tslint

Rule: radix

Requires the radix parameter to be specified when calling parseInt.

Rationale

From MDN:

Always specify this parameter to eliminate reader confusion and to guarantee predictable behavior. Different implementations produce different results when a radix is not specified, usually defaulting the value to 10.

Config

Not configurable.

Examples
"radix": true

For more information see this page.

There are no issues that match your filters.

Category
Status