Sign upLogin

knipknap/exscript

View on GitHub
Star
Exscript/servers/httpd.py

Summary

Maintainability
C
1 day
Test Coverage

Function _require_authenticate has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

def _require_authenticate(func):
    '''A decorator to add digest authorization checks to HTTP Request Handlers'''

    def wrapped(self):
        if not hasattr(self, 'authenticated'):
Severity: Minor
Found in Exscript/servers/httpd.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return func(self)
Severity: Major
Found in Exscript/servers/httpd.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return _error_401(self, 'qop with missing nc or cnonce')
    Severity: Major
    Found in Exscript/servers/httpd.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return _error_401(self, 'Invalid username or password')
      Severity: Major
      Found in Exscript/servers/httpd.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return _error_401(self, 'Invalid username or password')
        Severity: Major
        Found in Exscript/servers/httpd.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return _error_401(self, 'Incorrect realm')
          Severity: Major
          Found in Exscript/servers/httpd.py - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                def handle_POST(self):
        """
        Overwrite this method to handle a POST request. The default
        action is to respond with "error 404 (not found)".
        """
            Severity: Major
            Found in Exscript/servers/httpd.py and 1 other location - About 1 hr to fix
            Exscript/servers/httpd.py on lines 274..281

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 42.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                def handle_GET(self):
        """
        Overwrite this method to handle a GET request. The default
        action is to respond with "error 404 (not found)".
        """
            Severity: Major
            Found in Exscript/servers/httpd.py and 1 other location - About 1 hr to fix
            Exscript/servers/httpd.py on lines 265..272

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 42.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status