knipknap/exscript

View on GitHub
Exscript/util/crypt.py

Summary

Maintainability
B
4 hrs
Test Coverage

File crypt.py has 346 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#
# Copyright (C) 2010-2017 Samuel Abels
# The MIT License (MIT)
#
# Permission is hereby granted, free of charge, to any person obtaining
Severity: Minor
Found in Exscript/util/crypt.py - About 4 hrs to fix

    Function otp has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def otp(password, seed, sequence):
        """
        Calculates a one-time password hash using the given password, seed, and
        sequence number and returns it.
        Uses the MD4/sixword algorithm as supported by TACACS+ servers.
    Severity: Minor
    Found in Exscript/util/crypt.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status