Sign upLogin

knipknap/exscript

View on GitHub
Star
Exscript/workqueue/pipeline.py

Summary

Maintainability
B
4 hrs
Test Coverage

Pipeline has 28 functions (exceeds 20 allowed). Consider refactoring.
Open

class Pipeline(object):

    """
    A collection that is similar to Python's Queue object, except
    it also tracks items that are currently sleeping or in progress.
Severity: Minor
Found in Exscript/workqueue/pipeline.py - About 3 hrs to fix

    Function __next__ has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def __next__(self):
        with self.condition:
            while self.running:
                if self.paused:
                    self.condition.wait()
    Severity: Minor
    Found in Exscript/workqueue/pipeline.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _get_next has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def _get_next(self, pop=True):
        # We need to leave sleeping items in the queue because else we
        # would not know their original position after they wake up.
        # So we need to temporarily remove sleeping items from the top of
        # the queue here.
    Severity: Minor
    Found in Exscript/workqueue/pipeline.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status