knipknap/exscript

View on GitHub
Exscript/workqueue/workqueue.py

Summary

Maintainability
C
1 day
Test Coverage

File workqueue.py has 260 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#
# Copyright (C) 2010-2017 Samuel Abels
# The MIT License (MIT)
#
# Permission is hereby granted, free of charge, to any person obtaining
Severity: Minor
Found in Exscript/workqueue/workqueue.py - About 2 hrs to fix

    Function priority_enqueue has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def priority_enqueue(self,
    Severity: Minor
    Found in Exscript/workqueue/workqueue.py - About 35 mins to fix

      Function priority_enqueue_or_raise has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def priority_enqueue_or_raise(self,
      Severity: Minor
      Found in Exscript/workqueue/workqueue.py - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def priority_enqueue_or_raise(self,
                                          function,
                                          name=None,
                                          force_start=False,
                                          times=1,
        Severity: Major
        Found in Exscript/workqueue/workqueue.py and 1 other location - About 1 hr to fix
        Exscript/workqueue/workqueue.py on lines 161..191

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 41.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def priority_enqueue(self,
                                 function,
                                 name=None,
                                 force_start=False,
                                 times=1,
        Severity: Major
        Found in Exscript/workqueue/workqueue.py and 1 other location - About 1 hr to fix
        Exscript/workqueue/workqueue.py on lines 193..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 41.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def enqueue_or_ignore(self, function, name=None, times=1, data=None):
                """
                Like enqueue(), but does nothing if a function with the same name
                is already in the queue.
                Returns a job id if a new job was added, returns None otherwise.
        Severity: Major
        Found in Exscript/workqueue/workqueue.py and 1 other location - About 1 hr to fix
        Exscript/workqueue/workqueue.py on lines 120..139

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 38.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def enqueue(self, function, name=None, times=1, data=None):
                """
                Appends a function to the queue for execution. The times argument
                specifies the number of attempts if the function raises an exception.
                If the name argument is None it defaults to whatever id(function)
        Severity: Major
        Found in Exscript/workqueue/workqueue.py and 1 other location - About 1 hr to fix
        Exscript/workqueue/workqueue.py on lines 141..159

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 38.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status