Sign upLogin

knsv/mermaid

View on GitHub
Star

Showing 1,488 of 1,488 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const svg = securityLevel === 'sandbox' ? root.select(`[id="${id}"]`) : d3select(`[id="${id}"]`);
Severity: Minor
Found in packages/mermaid/src/diagrams/sankey/sankeyRenderer.ts and 1 other location - About 35 mins to fix
packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts on lines 773..774

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const diagram =
    securityLevel === 'sandbox' ? root.select(`[id="${id}"]`) : select(`[id="${id}"]`);
Severity: Minor
Found in packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts and 1 other location - About 35 mins to fix
packages/mermaid/src/diagrams/sankey/sankeyRenderer.ts on lines 60..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    cardinalityPosition.x = Math.sin(angle) * d + (points[0].x + center.x) / 2;
Severity: Minor
Found in packages/mermaid/src/utils.ts and 1 other location - About 35 mins to fix
packages/mermaid/src/utils.ts on lines 388..388

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const root =
    securityLevel === 'sandbox'
      ? d3select(sandboxElement.nodes()[0].contentDocument.body)
      : d3select('body');
Severity: Minor
Found in packages/mermaid/src/diagrams/sankey/sankeyRenderer.ts and 1 other location - About 35 mins to fix
packages/mermaid/src/diagrams/user-journey/journeyRenderer.ts on lines 59..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  cardinalityPosition.x = Math.sin(angle) * d + (points[0].x + center.x) / 2;
Severity: Minor
Found in packages/mermaid/src/utils.ts and 1 other location - About 35 mins to fix
packages/mermaid/src/utils.ts on lines 434..434

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

    return [
      { x: 0, y: 0 },
      { x: width, y: -midpoint },
      { x: 0, y: -height },
    ];
Severity: Major
Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return [
      // Bottom center
      { x: midpoint, y: -padding },
      // Left top over vertical section
      { x: midpoint, y: -height + padding },
    Severity: Major
    Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        return dst;
      Severity: Major
      Found in packages/mermaid/src/assignWithDepth.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return [
      { x: width, y: 0 },
      { x: 0, y: -midpoint },
      { x: 0, y: -height + midpoint },
      { x: width, y: -height },
        Severity: Major
        Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            return [{ x: 0, y: 0 }];
          Severity: Major
          Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return [
      { x: 0, y: 0 },
      { x: width, y: 0 },
      { x: 0, y: -height },
    ];
            Severity: Major
            Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return [
      { x: midpoint, y: 0 },
      { x: midpoint, y: -padding },
      { x: width - midpoint, y: -padding },
      { x: width - midpoint, y: 0 },
              Severity: Major
              Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return [
      { x: width, y: 0 },
      { x: 0, y: -midpoint },
      { x: width, y: -height },
    ];
                Severity: Major
                Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return [
      { x: midpoint, y: -padding },
      { x: midpoint, y: -padding },
      { x: width - midpoint, y: -padding },
      { x: width - midpoint, y: 0 },
                  Severity: Major
                  Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return [
      { x: width, y: 0 },
      { x: 0, y: 0 },
      { x: width, y: -height },
    ];
                    Severity: Major
                    Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return `Unsupported markdown: ${node.type}`;
                      Severity: Major
                      Found in packages/mermaid/src/rendering-util/handle-markdown-text.ts - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                            return [
      // Bottom center
      { x: width / 2, y: 0 },
      // Left pont of bottom arrow
      { x: 0, y: -padding },
                        Severity: Major
                        Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              return [
      { x: midpoint, y: 0 },
      { x: midpoint, y: -padding },
      // Two points, the right corners
      { x: width - midpoint, y: -padding },
                          Severity: Major
                          Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                return [
      // Bottom center
      { x: width / 2, y: 0 },
      // Left pont of bottom arrow
      { x: 0, y: -padding },
                            Severity: Major
                            Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

                              Identical blocks of code found in 4 locations. Consider refactoring.
                              Open

                                const shapeSvg = parent
    .insert('g')
    .attr('class', 'node default')
    .attr('id', node.domId || node.id);
                              Severity: Major
                              Found in packages/mermaid/src/dagre-wrapper/nodes.js and 3 other locations - About 30 mins to fix
                              packages/mermaid/src/dagre-wrapper/nodes.js on lines 807..810
                              packages/mermaid/src/dagre-wrapper/nodes.js on lines 826..829
                              packages/mermaid/src/dagre-wrapper/nodes.js on lines 858..861

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 45.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Severity
                              Category
                              Status
                              Source
                              Language