Sign upLogin

knsv/mermaid

View on GitHub
Star
packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts

Summary

Maintainability
D
1 day
Test Coverage

Function getArrowPoints has 169 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const getArrowPoints = (
  duplicatedDirections: Direction[],
  bbox: { width: number; height: number },
  node: any
) => {
Severity: Major
Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 6 hrs to fix

    Avoid too many return statements within this function.
    Open

        return [
      { x: 0, y: 0 },
      { x: width, y: -midpoint },
      { x: 0, y: -height },
    ];
    Severity: Major
    Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return [
      // Bottom center
      { x: midpoint, y: -padding },
      // Left top over vertical section
      { x: midpoint, y: -height + padding },
      Severity: Major
      Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return [
      { x: width, y: 0 },
      { x: 0, y: -midpoint },
      { x: 0, y: -height + midpoint },
      { x: width, y: -height },
        Severity: Major
        Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            return [{ x: 0, y: 0 }];
          Severity: Major
          Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return [
      { x: 0, y: 0 },
      { x: width, y: 0 },
      { x: 0, y: -height },
    ];
            Severity: Major
            Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return [
      { x: midpoint, y: 0 },
      { x: midpoint, y: -padding },
      { x: width - midpoint, y: -padding },
      { x: width - midpoint, y: 0 },
              Severity: Major
              Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return [
      { x: width, y: 0 },
      { x: 0, y: -midpoint },
      { x: width, y: -height },
    ];
                Severity: Major
                Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return [
      { x: midpoint, y: -padding },
      { x: midpoint, y: -padding },
      { x: width - midpoint, y: -padding },
      { x: width - midpoint, y: 0 },
                  Severity: Major
                  Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return [
      { x: width, y: 0 },
      { x: 0, y: 0 },
      { x: width, y: -height },
    ];
                    Severity: Major
                    Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return [
      // Bottom center
      { x: width / 2, y: 0 },
      // Left pont of bottom arrow
      { x: 0, y: -padding },
                      Severity: Major
                      Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                            return [
      { x: midpoint, y: 0 },
      { x: midpoint, y: -padding },
      // Two points, the right corners
      { x: width - midpoint, y: -padding },
                        Severity: Major
                        Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              return [
      // Bottom center
      { x: width / 2, y: 0 },
      // Left pont of bottom arrow
      { x: 0, y: -padding },
                          Severity: Major
                          Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts - About 30 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                return [
      { x: midpoint, y: 0 },
      { x: width - midpoint, y: 0 },
      { x: width, y: -height / 2 },
      { x: width - midpoint, y: -height },
                            Severity: Major
                            Found in packages/mermaid/src/dagre-wrapper/blockArrowHelper.ts and 1 other location - About 3 hrs to fix
                            packages/mermaid/src/diagrams/mindmap/svgDraw.ts on lines 148..155

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 98.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status