Sign upLogin

knsv/mermaid

View on GitHub
Star
packages/mermaid/src/diagram-api/comments.spec.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  it('should remove empty newlines from start', () => {
    const text = `
Severity: Major
Found in packages/mermaid/src/diagram-api/comments.spec.ts and 13 other locations - About 40 mins to fix
packages/mermaid/src/diagram-api/comments.spec.ts on lines 7..21
packages/mermaid/src/diagram-api/comments.spec.ts on lines 23..47
packages/mermaid/src/diagram-api/comments.spec.ts on lines 49..63
packages/mermaid/src/diagram-api/comments.spec.ts on lines 82..93
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 13..23
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 25..33
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 56..68
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 70..82
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 84..96
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 98..108
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 110..120
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 122..132
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 139..170

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  it('should remove comments', () => {
    const text = `

%% This is a comment
%% This is another comment
Severity: Major
Found in packages/mermaid/src/diagram-api/comments.spec.ts and 13 other locations - About 40 mins to fix
packages/mermaid/src/diagram-api/comments.spec.ts on lines 23..47
packages/mermaid/src/diagram-api/comments.spec.ts on lines 49..63
packages/mermaid/src/diagram-api/comments.spec.ts on lines 65..80
packages/mermaid/src/diagram-api/comments.spec.ts on lines 82..93
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 13..23
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 25..33
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 56..68
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 70..82
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 84..96
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 98..108
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 110..120
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 122..132
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 139..170

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  it('should keep init statements when removing comments', () => {
    const text = `
%% This is a comment

%% This is another comment
Severity: Major
Found in packages/mermaid/src/diagram-api/comments.spec.ts and 13 other locations - About 40 mins to fix
packages/mermaid/src/diagram-api/comments.spec.ts on lines 7..21
packages/mermaid/src/diagram-api/comments.spec.ts on lines 49..63
packages/mermaid/src/diagram-api/comments.spec.ts on lines 65..80
packages/mermaid/src/diagram-api/comments.spec.ts on lines 82..93
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 13..23
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 25..33
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 56..68
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 70..82
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 84..96
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 98..108
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 110..120
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 122..132
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 139..170

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  it('should remove indented comments', () => {
    const text = `
%% This is a comment
graph TD
    A-->B
Severity: Major
Found in packages/mermaid/src/diagram-api/comments.spec.ts and 13 other locations - About 40 mins to fix
packages/mermaid/src/diagram-api/comments.spec.ts on lines 7..21
packages/mermaid/src/diagram-api/comments.spec.ts on lines 23..47
packages/mermaid/src/diagram-api/comments.spec.ts on lines 65..80
packages/mermaid/src/diagram-api/comments.spec.ts on lines 82..93
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 13..23
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 25..33
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 56..68
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 70..82
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 84..96
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 98..108
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 110..120
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 122..132
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 139..170

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  it('should remove comments at end of text with no newline', () => {
    const text = `
graph TD
    A-->B
%% This is a comment`;
Severity: Major
Found in packages/mermaid/src/diagram-api/comments.spec.ts and 13 other locations - About 40 mins to fix
packages/mermaid/src/diagram-api/comments.spec.ts on lines 7..21
packages/mermaid/src/diagram-api/comments.spec.ts on lines 23..47
packages/mermaid/src/diagram-api/comments.spec.ts on lines 49..63
packages/mermaid/src/diagram-api/comments.spec.ts on lines 65..80
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 13..23
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 25..33
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 56..68
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 70..82
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 84..96
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 98..108
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 110..120
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 122..132
packages/mermaid/src/diagram-api/frontmatter.spec.ts on lines 139..170

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status