knsv/mermaid

View on GitHub
packages/mermaid/src/diagrams/user-journey/journeyRenderer.ts

Summary

Maintainability
F
3 days
Test Coverage

Function draw has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const draw = function (text, id, version, diagObj) {
  const conf = getConfig().journey;

  const securityLevel = getConfig().securityLevel;
  // Handle root and Document for when rendering in sandbox mode
Severity: Major
Found in packages/mermaid/src/diagrams/user-journey/journeyRenderer.ts - About 2 hrs to fix

    Function drawTasks has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const drawTasks = function (diagram, tasks, verticalPos) {
      const conf = getConfig().journey;
      let lastSection = '';
      const sectionVHeight = conf.height * 2 + conf.diagramMarginY;
      const taskPos = verticalPos + sectionVHeight;
    Severity: Major
    Found in packages/mermaid/src/diagrams/user-journey/journeyRenderer.ts - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          function updateFn(type?: 'activation') {
            return function updateItemBounds(item) {
              cnt++;
              // The loop sequenceItems is a stack so the biggest margins in the beginning of the sequenceItems
              const n = _self.sequenceItems.length - cnt + 1;
      packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts on lines 108..128

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 329.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        insert: function (startx, starty, stopx, stopy) {
          const _startx = Math.min(startx, stopx);
          const _stopx = Math.max(startx, stopx);
          const _starty = Math.min(starty, stopy);
          const _stopy = Math.max(starty, stopy);
      packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts on lines 133..145

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 180.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        updateVal: function (obj, key, val, fun) {
          if (obj[key] === undefined) {
            obj[key] = val;
          } else {
            obj[key] = fun(val, obj[key]);
      packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts on lines 96..102

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        const root =
          securityLevel === 'sandbox'
            ? select(sandboxElement.nodes()[0].contentDocument.body)
            : select('body');
      Severity: Minor
      Found in packages/mermaid/src/diagrams/user-journey/journeyRenderer.ts and 1 other location - About 35 mins to fix
      packages/mermaid/src/diagrams/sankey/sankeyRenderer.ts on lines 55..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status