Sign upLogin

kodadot/nft-gallery

View on GitHub
Star
composables/transaction/transactionBuy.ts

Summary

Maintainability
B
4 hrs
Test Coverage

Function payRoyaltyAssetHub has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function payRoyaltyAssetHub(
  legacy,
  api,
  price,
  royalty,
Severity: Minor
Found in composables/transaction/transactionBuy.ts - About 1 hr to fix

    Function execBuyStatemine has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function execBuyStatemine(item: ActionBuy, api, executeTransaction) {
  const nfts = Array.isArray(item.nfts) ? item.nfts : [item.nfts]
  const transactions = await Promise.all(
    nfts.map(async ({ id: nftId, price, royalty }) => {
      const legacy = isLegacy(nftId)
    Severity: Minor
    Found in composables/transaction/transactionBuy.ts - About 1 hr to fix

      Function payRoyaltyAssetHub has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        legacy,
  api,
  price,
  royalty,
  collectionId,
      Severity: Minor
      Found in composables/transaction/transactionBuy.ts - About 45 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          executeTransaction({
    cb: api.tx.utility.batchAll,
    arg: [transactions.flat()],
    successMessage: item.successMessage,
    errorMessage: item.errorMessage,
        Severity: Major
        Found in composables/transaction/transactionBuy.ts and 2 other locations - About 1 hr to fix
        composables/transaction/transactionCreateSwap.ts on lines 39..44
        composables/transaction/transactionOffer.ts on lines 52..57

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status