kodadot/nft-gallery

View on GitHub

Showing 177 of 177 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  executeTransaction({
    cb: api.tx.utility.batchAll,
    arg: [transactions.flat()],
    successMessage: item.successMessage,
    errorMessage: item.errorMessage,
Severity: Major
Found in composables/transaction/transactionBuy.ts and 2 other locations - About 1 hr to fix
composables/transaction/transactionCreateSwap.ts on lines 39..44
composables/transaction/transactionOffer.ts on lines 52..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 57.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  executeTransaction({
    cb: api.tx.utility.batchAll,
    arg: [transactions.flat()],
    successMessage: item.successMessage,
    errorMessage: item.errorMessage,
Severity: Major
Found in composables/transaction/transactionOffer.ts and 2 other locations - About 1 hr to fix
composables/transaction/transactionBuy.ts on lines 92..97
composables/transaction/transactionCreateSwap.ts on lines 39..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 57.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function useWaitingItems has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

export const useWaitingItems = () => {
  const { urlPrefix } = usePrefix()
  const { accountId } = useAuth()
  const { client } = usePrefix()

Severity: Minor
Found in composables/useMigrate.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function default has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

export default function () {
  const { urlPrefix } = usePrefix()
  const identityStore = useIdentityStore()

  const getBalance = (_token: string) => {
Severity: Minor
Found in composables/useBalance.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function default has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

export default function<T = unknown>({
  queryPrefix = '',
  queryName,
  clientName = '',
  variables = {},
Severity: Minor
Found in composables/useGraphql.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getRedirectPathForPrefix has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

function getRedirectPathForPrefix({
  routeName,
  chain,
  route,
}: {
Severity: Minor
Found in composables/useChainRedirect.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function useIcon has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const useIcon = () => {
  const { isDarkMode } = useTheme()

  const signUpVoucherIcon = computed(() =>
    isDarkMode.value ? '/signup-voucher-dark.svg' : '/signup-voucher.svg',
Severity: Minor
Found in composables/useIcon.ts - About 1 hr to fix

    Function default has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export default function (modalRef: Ref) {
      const targetModals = ref<ModalRef[]>([])
      const symbol = Symbol()
    
      const otherModals = computed(() => {
    Severity: Minor
    Found in composables/useModalManager.ts - About 1 hr to fix

      Function useCreate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export default function useCreate() {
        const showExplainerText = ref(false)
        const { replaceUrl } = useReplaceUrl()
        const route = useRoute()
        const components = [CreateComponent.Collection, CreateComponent.NFT]
      Severity: Minor
      Found in composables/useCreate.ts - About 1 hr to fix

        Function useNftActions has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function useNftActions(entity: TokenEntity) {
          const { isCurrentOwner } = useAuth()
        
          const cheapestNFT = ref<NFTWithMetadata>()
        
        
        Severity: Minor
        Found in components/items/ItemsGrid/useNftActions.ts - About 1 hr to fix

          Function default has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export default function () {
            const { disconnectAsync: disconnectWeb3Modal } = useDisconnect()
            const shoppingCartStore = useShoppingCartStore()
            const walletStore = useWalletStore()
            const identityStore = useIdentityStore()
          Severity: Minor
          Found in composables/useWallet.ts - About 1 hr to fix

            Function fetchWaitingItems has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              const fetchWaitingItems = async () => {
                const { data } = await useAsyncQuery<Collections>({
                  query: collectionMigrateWaiting,
                  variables: {
                    account: accountId.value,
            Severity: Minor
            Found in composables/useMigrate.ts - About 1 hr to fix

              Function formatSecondsToDuration has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export const formatSecondsToDuration = (seconds: number) => {
                const duration = intervalToDuration({
                  start: new Date(),
                  end: addSeconds(new Date(), seconds),
                })
              Severity: Minor
              Found in utils/format/time.ts - About 1 hr to fix

                Function execBurnAssetHub has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function execBurnAssetHub(item: ActionConsume, api: ApiPromise, executeTransaction: ExecuteTransaction) {
                  const getApiCallParams = (nftId: string) => {
                    const legacy = isLegacy(nftId)
                    const paramResolver = assetHubParamResolver(legacy)
                
                
                Severity: Minor
                Found in composables/transaction/transactionBurn.ts - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  export const nftActionResolver: CallDictionary = {
                    SEND: ['nfts', 'transfer'],
                    CONSUME: ['nfts', 'burn'],
                    BUY: ['nfts', 'buyItem'],
                    LIST: ['nfts', 'setPrice'],
                  Severity: Minor
                  Found in utils/gallery/abstractCalls.ts and 1 other location - About 55 mins to fix
                  utils/gallery/abstractCalls.ts on lines 6..15

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 54.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  export const uniqueActionResolver: CallDictionary = {
                    SEND: ['uniques', 'transfer'],
                    CONSUME: ['uniques', 'burn'],
                    BUY: ['uniques', 'buyItem'],
                    LIST: ['uniques', 'setPrice'],
                  Severity: Minor
                  Found in utils/gallery/abstractCalls.ts and 1 other location - About 55 mins to fix
                  utils/gallery/abstractCalls.ts on lines 17..26

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 54.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function formatNumber has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                  export function formatNumber(amount?: string | number): string {
                    if (!amount) {
                      return '0'
                    }
                    const number
                  Severity: Minor
                  Found in utils/format/balance.ts - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function sortedEventByDate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                  export const sortedEventByDate = (
                    events: Interaction[],
                    order = 'ASC',
                  ): Interaction[] => {
                    if (events.length == 0) {
                  Severity: Minor
                  Found in utils/sorting.ts - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function resolveMedia has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                  export function resolveMedia(mimeType?: string): MediaType {
                    if (!mimeType) {
                      return MediaType.UNKNOWN
                    }
                  
                  
                  Severity: Minor
                  Found in utils/gallery/media.ts - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  export const fetchOdaCollection = (chain: Prefix, address: string) => {
                    return api<OnchainCollection>(`/v1/${chain}/collection/${address}`)
                  }
                  Severity: Minor
                  Found in services/oda.ts and 1 other location - About 55 mins to fix
                  services/oda.ts on lines 29..31

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 53.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language