koenvervloesem/snipskit

View on GitHub
src/snipskit/config.py

Summary

Maintainability
B
4 hrs
Test Coverage

File config.py has 281 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""This module gives a way to access the configuration of a locally installed
instance of Snips, a Snips assistant and a Snips skill.

Classes:

Severity: Minor
Found in src/snipskit/config.py - About 2 hrs to fix

    Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, hostname=None, ca_file=None, ca_path=None,
    Severity: Minor
    Found in src/snipskit/config.py - About 45 mins to fix

      Function __init__ has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def __init__(self, filename=None):
              """Initialize a :class:`.SnipsConfig` object.
      
              The :attr:`mqtt` attribute is initialized with the MQTT connection
              settings from the configuration file, or the default value
      Severity: Minor
      Found in src/snipskit/config.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Line too long (92 > 79 characters)
      Open

                  tls_disable_root_store = self['snips-common'].get('mqtt_tls_disable_root_store',
      Severity: Minor
      Found in src/snipskit/config.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      There are no issues that match your filters.

      Category
      Status