koki-develop/clive

View on GitHub

Showing 9 of 9 total issues

Method Model.Update has 13 return statements (exceeds 4 allowed).
Open

func (m *Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
    switch msg := msg.(type) {
    // spinner
    case spinner.TickMsg:
        var cmd tea.Cmd
Severity: Major
Found in internal/ui/update.go - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func parseCtrlAction(settings *Settings, m map[string]interface{}) (Action, error) {
        if err := validateActionFields(m, ctrlActionValidFields); err != nil {
            return nil, err
        }
    
    
    Severity: Major
    Found in internal/config/action.go and 1 other location - About 1 hr to fix
    internal/config/action.go on lines 118..132

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 141.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func parseTypeAction(stgs *Settings, m map[string]interface{}) (Action, error) {
        if err := validateActionFields(m, typeActionValidFields); err != nil {
            return nil, err
        }
    
    
    Severity: Major
    Found in internal/config/action.go and 1 other location - About 1 hr to fix
    internal/config/action.go on lines 180..194

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 141.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func (m *Model) runCtrl(action *config.CtrlAction) tea.Msg {
        for i := 0; i < action.Count; i++ {
            if err := m.runCtrlOnce(action); err != nil {
                return errMsg{err}
            }
    Severity: Major
    Found in internal/ui/update.go and 2 other locations - About 45 mins to fix
    internal/ui/update.go on lines 196..207
    internal/ui/update.go on lines 254..265

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func (m *Model) runKey(action *config.KeyAction) tea.Msg {
        for i := 0; i < action.Count; i++ {
            if err := m.runKeyOnce(action); err != nil {
                return errMsg{err}
            }
    Severity: Major
    Found in internal/ui/update.go and 2 other locations - About 45 mins to fix
    internal/ui/update.go on lines 196..207
    internal/ui/update.go on lines 289..300

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func (m *Model) runType(action *config.TypeAction) tea.Msg {
        for i := 0; i < action.Count; i++ {
            if err := m.runTypeOnce(action); err != nil {
                return errMsg{err}
            }
    Severity: Major
    Found in internal/ui/update.go and 2 other locations - About 45 mins to fix
    internal/ui/update.go on lines 254..265
    internal/ui/update.go on lines 289..300

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method Model.runScreenshot has 6 return statements (exceeds 4 allowed).
    Open

    func (m *Model) runScreenshot(action *config.ScreenshotAction) tea.Msg {
        if err := m.setCursorBlink(false); err != nil {
            return errMsg{err}
        }
    
    
    Severity: Major
    Found in internal/ui/update.go - About 40 mins to fix

      Method Model.setupPage has 6 return statements (exceeds 4 allowed).
      Open

      func (m *Model) setupPage(page *rod.Page) error {
          // window size
          if m.config.Settings.Width != nil || m.config.Settings.Height != nil {
              if err := page.SetWindow(&proto.BrowserBounds{Width: m.config.Settings.Width, Height: m.config.Settings.Height}); err != nil {
                  return err
      Severity: Major
      Found in internal/ui/update.go - About 40 mins to fix

        Function notifyNewRelease has 6 return statements (exceeds 4 allowed).
        Open

        func notifyNewRelease(w io.Writer) error {
            s, err := cache.NewStore(12 * time.Hour)
            if err != nil {
                return err
            }
        Severity: Major
        Found in cmd/notify.go - About 40 mins to fix
          Severity
          Category
          Status
          Source
          Language