Sign upLogin

koki-develop/gat

View on GitHub
Star

Showing 7 of 7 total issues

Method Gat.Print has a Cognitive Complexity of 45 (exceeds 20 allowed). Consider refactoring.
Open

func (g *Gat) Print(w io.Writer, r io.Reader, opts ...PrintOption) error {
    // parse options
    opt := &printOption{}
    for _, o := range opts {
        o(opt)
Severity: Minor
Found in internal/gat/gat.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package formatters

import (
    "bytes"
    "io"
Severity: Major
Found in internal/formatters/json_minified.go and 1 other location - About 3 hrs to fix
internal/formatters/svg_minified.go on lines 1..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 274.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package formatters

import (
    "bytes"
    "io"
Severity: Major
Found in internal/formatters/svg_minified.go and 1 other location - About 3 hrs to fix
internal/formatters/json_minified.go on lines 1..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 274.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method Gat.Print has 85 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (g *Gat) Print(w io.Writer, r io.Reader, opts ...PrintOption) error {
    // parse options
    opt := &printOption{}
    for _, o := range opts {
        o(opt)
Severity: Major
Found in internal/gat/gat.go - About 2 hrs to fix

    Method Gat.Print has 16 return statements (exceeds 4 allowed).
    Open

    func (g *Gat) Print(w io.Writer, r io.Reader, opts ...PrintOption) error {
    // parse options
    opt := &printOption{}
    for _, o := range opts {
        o(opt)
    Severity: Major
    Found in internal/gat/gat.go - About 1 hr to fix

      Method XMLPrettier.Pretty has 6 return statements (exceeds 4 allowed).
      Open

      func (*XMLPrettier) Pretty(input string) (string, error) {
    var b bytes.Buffer
    dec := xml.NewDecoder(strings.NewReader(input))
    enc := xml.NewEncoder(&b)
    enc.Indent("", "  ")
      Severity: Major
      Found in internal/prettier/xml.go - About 40 mins to fix

        Function PrintThemes has 5 return statements (exceeds 4 allowed).
        Open

        func PrintThemes(w io.Writer) error {
    src := `package main

import "fmt"
        Severity: Major
        Found in internal/gat/gat.go - About 35 mins to fix
          Severity
          Category
          Status
          Source
          Language