Sign upLogin

koki-develop/qiita-cli

View on GitHub
Star
internal/cli/items.go

Summary

Maintainability
A
3 hrs
Test Coverage

Method CLI.ItemsPull has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
Open

func (c *CLI) ItemsPull(params *ItemsPullParameters) error {
    all := *params.FlagAll.Get(c.command, true)
    if all && len(params.Args) > 0 {
        return ErrIDsWithAll
    }
Severity: Minor
Found in internal/cli/items.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method CLI.ItemsPull has 8 return statements (exceeds 4 allowed).
Open

func (c *CLI) ItemsPull(params *ItemsPullParameters) error {
    all := *params.FlagAll.Get(c.command, true)
    if all && len(params.Args) > 0 {
        return ErrIDsWithAll
    }
Severity: Major
Found in internal/cli/items.go - About 50 mins to fix

    Method CLI.ItemsNew has 5 return statements (exceeds 4 allowed).
    Open

    func (c *CLI) ItemsNew(params *ItemsNewParameters) error {
    filename := params.Args[0]
    if !strings.HasSuffix(filename, ".md") {
        filename += ".md"
    }
    Severity: Major
    Found in internal/cli/items.go - About 35 mins to fix

      Method CLI.ItemsPush has 5 return statements (exceeds 4 allowed).
      Open

      func (c *CLI) ItemsPush(params *ItemsPushParameters) error {
    for _, filename := range params.Args {
        md, fm, err := c.readMarkdown(filename)
        if err != nil {
            return err
      Severity: Major
      Found in internal/cli/items.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status