Sign upLogin

kolatz/umbr_api

View on GitHub
Star
umbr_api/management.py

Summary

Maintainability
C
7 hrs
Test Coverage

Function json_to_table has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

def json_to_table(
    _json, exclude_col=None
):  # pylint: disable=too-many-branches
    """Convert json object to table."""
    if not _json:
Severity: Minor
Found in umbr_api/management.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function management_api has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def management_api(command, orgid=None, cred=None, limit=10, page=1, **kwargs):
Severity: Minor
Found in umbr_api/management.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        if isinstance(sub_value, list):
                        line.append("\n".join(sub_value))
                    else:
                        line.append(sub_value)
            else:
    Severity: Major
    Found in umbr_api/management.py - About 45 mins to fix

      Function find_columns has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def find_columns(items_to_look_for, list_to_search_in):
    """Search entries of list items in a list, return indexes."""
    found_indexes = []  # to collect numbers of columns to remove
    for item_to_look_for in items_to_look_for:
        # search multiple entries
      Severity: Minor
      Found in umbr_api/management.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          if isinstance(sub_value, list):
                        line.append("\n".join(sub_value))
                    else:
                        line.append(sub_value)
      Severity: Minor
      Found in umbr_api/management.py and 1 other location - About 40 mins to fix
      umbr_api/management.py on lines 95..98

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      if isinstance(value, list):
                    line.append("\n".join(value))
                else:
                    line.append(value)
      Severity: Minor
      Found in umbr_api/management.py and 1 other location - About 40 mins to fix
      umbr_api/management.py on lines 90..93

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status