Sign upLogin

konstantin1998/frontend-project-lvl2

View on GitHub
Star

Showing 7 of 7 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

test.each(arraysForTest)('plainFormatTest', (before, after) => {
  const fileBeforePath = `${testDirPath}/${before}`;
  const fileAfterPath = `${testDirPath}/${after}`;
  const rightAnswerPath = `${rightAnswersDirPath}/plainFormat`;
  const format = 'plain';
Severity: Major
Found in __tests__/compare.test.js and 1 other location - About 5 hrs to fix
__tests__/compare.test.js on lines 12..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 150.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

test.each(arraysForTest)('objFormatTest', (before, after) => {
  const fileBeforePath = `${testDirPath}/${before}`;
  const fileAfterPath = `${testDirPath}/${after}`;
  const rightAnswerPath = `${rightAnswersDirPath}/objFormat`;
  const format = 'obj';
Severity: Major
Found in __tests__/compare.test.js and 1 other location - About 5 hrs to fix
__tests__/compare.test.js on lines 23..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 150.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function differenceItem has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const differenceItem = (objBefore, objAfter, key) => {
  if (_.has(objBefore, key) && _.has(objAfter, key)) {
    if (objBefore[key] === objAfter[key]) {
      return {
        name: key,
Severity: Minor
Found in src/differenceCreator.js - About 1 hr to fix

    Function iter has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const iter = (diffTree, level = 0) => {
  const gap = '  '.repeat(2 * level + 1);
  const passThroughTree = (item) => {
    switch (item.type) {
      case 'changed': {
    Severity: Minor
    Found in src/formatters/objDiffGenerator.js - About 1 hr to fix

      Function differenceItem has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      const differenceItem = (objBefore, objAfter, key) => {
  if (_.has(objBefore, key) && _.has(objAfter, key)) {
    if (objBefore[key] === objAfter[key]) {
      return {
        name: key,
      Severity: Minor
      Found in src/differenceCreator.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

              return [startLine, iter(item.children, level + 1), finishLine].join('\n');
      Severity: Major
      Found in src/formatters/objDiffGenerator.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return iter(item.children, newPath);
        Severity: Major
        Found in src/formatters/plainDiffGenerator.js - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language