kputnam/stupidedi

build/doc/lib/meta-plugin/lib/yard-meta/legacy.rb

Summary

B
5 hrs

Method process has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open

def process
params = []

if m = MATCH_A.match(statement.tokens.to_s)
name = m.captures.first
Found in build/doc/lib/meta-plugin/lib/yard-meta/legacy.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

Method process has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open

def process
params = []

if m = MATCH_A.match(statement.tokens.to_s)
name = m.captures.first
Found in build/doc/lib/meta-plugin/lib/yard-meta/legacy.rb - About 1 hr to fix

Method process has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open

def process
return unless m = MATCH.match(statement.tokens.to_s)

methods = m.captures.at(0).split(/\s*,\s*/)
target  = m.captures.at(2).slice(2..-1)
Found in build/doc/lib/meta-plugin/lib/yard-meta/legacy.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

Identical blocks of code found in 2 locations. Consider refactoring. Open

methods.each do |name|
name = name.slice(1..-1)

object = register(YARD::CodeObjects::MethodObject.new(namespace, name, scope)) do |o|
o.visibility = visibility
Found in build/doc/lib/meta-plugin/lib/yard-meta/legacy.rb and 1 other location - About 55 mins to fix
build/doc/lib/meta-plugin/lib/yard-meta/handler.rb on lines 96..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

Refactorings

Identical blocks of code found in 2 locations. Consider refactoring. Open

if name =~ /\?\$/
if object.has_tag?(:return)
tag = object.tag(:return)
if tag.types.nil? or tag.types.empty?
tag.types = %w(Boolean)
Found in build/doc/lib/meta-plugin/lib/yard-meta/legacy.rb and 1 other location - About 35 mins to fix
build/doc/lib/meta-plugin/lib/yard-meta/handler.rb on lines 32..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

Refactorings

Identical blocks of code found in 2 locations. Consider refactoring. Open

object = register(YARD::CodeObjects::MethodObject.new(namespace, name, scope)) do |o|
o.visibility = visibility
o.source     = statement.source
o.explicit   = false
o.signature  = signature(name, params)
Found in build/doc/lib/meta-plugin/lib/yard-meta/legacy.rb and 1 other location - About 25 mins to fix
build/doc/lib/meta-plugin/lib/yard-meta/handler.rb on lines 23..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.