Sign upLogin

krasnoukhov/lotus-dynamodb

View on GitHub
Star

Showing 4 of 4 total issues

Class Query has 37 methods (exceeds 20 allowed). Consider refactoring.
Open

        class Query
          include Enumerable
          extend  Forwardable

          def_delegators :all, :to_s, :empty?
Severity: Minor
Found in lib/lotus/model/adapters/dynamodb/query.rb - About 4 hrs to fix

    Class Coercer has 21 methods (exceeds 20 allowed). Consider refactoring.
    Open

            class Coercer < Lotus::Model::Mapping::Coercer
          SKIPPED_KLASSES = [Float, Integer, Set, String]
          SUPPORTED_KLASSES = [AWS::DynamoDB::Binary, Array, Boolean, Date, DateTime, Hash, Time]

          # Converts value from given type to DynamoDB record value.
    Severity: Minor
    Found in lib/lotus/model/adapters/dynamodb/coercer.rb - About 2 hrs to fix

      Method serialize_condition has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                def serialize_condition(condition, operator: nil, negate: false)
            column, value = condition.keys.first, condition.values.first

            operator ||= case
            when value.is_a?(Array)
      Severity: Minor
      Found in lib/lotus/model/adapters/dynamodb/query.rb - About 1 hr to fix

        Method continue? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

                  def continue?(previous_response)
            return false unless previous_response.last_evaluated_key

            if @options[:limit]
              if @options[:limit] > previous_response.count
        Severity: Minor
        Found in lib/lotus/model/adapters/dynamodb/query.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language