Sign upLogin

krateng/maloja

View on GitHub
Star
maloja/malojauri.py

Summary

Maintainability
C
1 day
Test Coverage

Function uri_to_internal has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

def uri_to_internal(keys,accepted_entities=('artist','track','album'),forceTrack=False,forceArtist=False,forceAlbum=False,api=False):

    # output:
    # 1    keys that define the filtered object like artist or track
    # 2    keys that define time limits of the whole thing
Severity: Minor
Found in maloja/malojauri.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function internal_to_uri has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

def internal_to_uri(keys):
    urikeys = FormsDict()

    #filter
    if "artist" in keys:
Severity: Minor
Found in maloja/malojauri.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function remove_identical has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def remove_identical(*dicts):
    #combine multiple dicts
    keys = FormsDict()
    for d in dicts:
        for k in d:
Severity: Minor
Found in maloja/malojauri.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function uri_to_internal has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def uri_to_internal(keys,accepted_entities=('artist','track','album'),forceTrack=False,forceArtist=False,forceAlbum=False,api=False):
Severity: Minor
Found in maloja/malojauri.py - About 45 mins to fix

    There are no issues that match your filters.

    Category
    Status