Sign upLogin

krateng/maloja

View on GitHub
Star
maloja/upgrade.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function upgrade_db has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

def upgrade_db(callback_add_scrobbles):

    oldfolder = os.path.join(dir_settings['state'],"scrobbles")
    newfolder = os.path.join(dir_settings['state'],".v2scrobbles")
    os.makedirs(newfolder,exist_ok=True)
Severity: Minor
Found in maloja/upgrade.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if duration in ('-',''): duration = None
                    scrobblelist.append({
Severity: Major
Found in maloja/upgrade.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        if album in ('-',''): album = None
                    if duration in ('-',''): duration = None
    Severity: Major
    Found in maloja/upgrade.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status