Sign upLogin

krautcomputing/active_record-acts_as

View on GitHub
Star

Showing 3 of 3 total issues

Method acts_as has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def acts_as(name, scope = nil, options = {})
          options, scope = scope, nil if Hash === scope

          association_method = options.delete(:association_method)
          touch              = options.delete(:touch)
Severity: Minor
Found in lib/active_record/acts_as/relation.rb - About 1 hr to fix

    Method acts_as has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

            def acts_as(name, scope = nil, options = {})
          options, scope = scope, nil if Hash === scope

          association_method = options.delete(:association_method)
          touch              = options.delete(:touch)
    Severity: Minor
    Found in lib/active_record/acts_as/relation.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method actable_must_be_valid has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def actable_must_be_valid
        unless acting_as.valid?
          acting_as.errors.messages.each do |attribute, messages|
            messages.each do |message|
              errors.add(attribute, message) unless errors[attribute].include?(message)
    Severity: Minor
    Found in lib/active_record/acts_as/instance_methods.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language