Sign upLogin

kristenmills/to-do

View on GitHub
Star

Showing 15 of 15 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        def finish task, is_num
            if is_num
                if !@tasks[task.to_i].nil?
                    @completed_tasks[task.to_i] = @tasks[task.to_i]
                    @tasks.delete(task.to_i)
Severity: Major
Found in lib/to-do/old/list.rb and 1 other location - About 2 hrs to fix
lib/to-do/old/list.rb on lines 90..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        def undo task, is_num
            if is_num
                if !@completed_tasks[task.to_i].nil?
                    @tasks[task.to_i] = @completed_tasks[task.to_i]
                    @completed_tasks.delete(task.to_i)
Severity: Major
Found in lib/to-do/old/list.rb and 1 other location - About 2 hrs to fix
lib/to-do/old/list.rb on lines 53..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method split has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

            def split string, width
                split = Array.new
                if string.length > width #if the string needs to be split
                    string_words = string.split(" ")
                    line = ""
Severity: Minor
Found in lib/to-do/helpers/helpers_CLI.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method split has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

            def split string, width
                split = Array.new
                if string.length > width #if the string needs to be split
                    string_words = string.split(" ")
                    line = ""
Severity: Minor
Found in lib/to-do/helpers/helpers_CLI.rb - About 1 hr to fix

    Method commands_parser has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

            def commands_parser
            if ARGV.count > 0
                should_display = command_switch
                if ARGV[0] == "clear"
                    Tasks.clear Helpers::CLI::OPTIONS[:clear_all]
    Severity: Minor
    Found in lib/to-do/cli.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method finish has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def finish task, is_num
            if is_num
                if !@tasks[task.to_i].nil?
                    @completed_tasks[task.to_i] = @tasks[task.to_i]
                    @tasks.delete(task.to_i)
    Severity: Minor
    Found in lib/to-do/old/list.rb - About 1 hr to fix

      Method undo has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def undo task, is_num
            if is_num
                if !@completed_tasks[task.to_i].nil?
                    @tasks[task.to_i] = @completed_tasks[task.to_i]
                    @completed_tasks.delete(task.to_i)
      Severity: Minor
      Found in lib/to-do/old/list.rb - About 1 hr to fix

        Method command_switch has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def command_switch 
            if ARGV.count > 1 
                should_display =  true
                case ARGV[0]
                when "create", "switch"
        Severity: Minor
        Found in lib/to-do/cli.rb - About 1 hr to fix

          Method finish has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                  def finish task, is_num
            if is_num
                if !@tasks[task.to_i].nil?
                    @completed_tasks[task.to_i] = @tasks[task.to_i]
                    @tasks.delete(task.to_i)
          Severity: Minor
          Found in lib/to-do/old/list.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method undo has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                  def undo task, is_num
            if is_num
                if !@completed_tasks[task.to_i].nil?
                    @tasks[task.to_i] = @completed_tasks[task.to_i]
                    @completed_tasks.delete(task.to_i)
          Severity: Minor
          Found in lib/to-do/old/list.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method update_task has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                      def update_task is_num, names, task, key, value
                if is_num
                    found_task = names[:Task_number => task]
                    if found_task
                        Helpers::DATABASE[:Tasks].filter(:Id => found_task[:Id]).update(key => value)
          Severity: Minor
          Found in lib/to-do/helpers/helpers_tasks.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method update_task has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                      def update_task is_num, names, task, key, value
          Severity: Minor
          Found in lib/to-do/helpers/helpers_tasks.rb - About 35 mins to fix

            Method command_switch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                    def command_switch 
            if ARGV.count > 1 
                should_display =  true
                case ARGV[0]
                when "create", "switch"
            Severity: Minor
            Found in lib/to-do/cli.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                up do
        rename_table :Tasks, :Old_tasks
        create_table :Tasks do
            primary_key :Id
            Integer :Task_number
            Severity: Minor
            Found in lib/to-do/dbmigrations/002_rename_name_column.rb and 1 other location - About 20 mins to fix
            lib/to-do/dbmigrations/002_rename_name_column.rb on lines 15..24

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 27.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                down do 
        rename_table :Tasks, :Old_tasks
        create_table :Tasks do
            primary_key :Id
            Integer :Task_number
            Severity: Minor
            Found in lib/to-do/dbmigrations/002_rename_name_column.rb and 1 other location - About 20 mins to fix
            lib/to-do/dbmigrations/002_rename_name_column.rb on lines 4..13

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 27.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language