Sign upLogin

krivtsov/project-lvl2-s93

View on GitHub
Star

Showing 15 of 15 total issues

Function getString has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

const getString = (ast) => {
  const iter = (tree, lvl) => {
    const indent = _.repeat(' ', 4 * lvl);
    const stringify = (elem) => {
      if (elem instanceof Object) {
Severity: Minor
Found in src/formats/string.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getDifferenceObjects has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const getDifferenceObjects = (firstObject, secondObject) => {
  const firstKeys = Object.keys(firstObject);
  const secondKeys = Object.keys(secondObject);
  const uniqKeys = _.union(firstKeys, secondKeys);
Severity: Major
Found in src/differ.js - About 2 hrs to fix

    Function arrayDiff has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const arrayDiff = uniqKeys.reduce((acc, key) => {
    if (key in firstObject && key in secondObject) {
      if (firstObject[key] instanceof Object || secondObject[key] instanceof Object) {
        const result = {
          type: '',
    Severity: Minor
    Found in src/differ.js - About 1 hr to fix

      Function getDifferenceObjects has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      const getDifferenceObjects = (firstObject, secondObject) => {
  const firstKeys = Object.keys(firstObject);
  const secondKeys = Object.keys(secondObject);
  const uniqKeys = _.union(firstKeys, secondKeys);
      Severity: Minor
      Found in src/differ.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getString has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const getString = (ast) => {
  const iter = (tree, lvl) => {
    const indent = _.repeat(' ', 4 * lvl);
    const stringify = (elem) => {
      if (elem instanceof Object) {
      Severity: Minor
      Found in src/formats/string.js - About 1 hr to fix

        Function iter has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          const iter = (tree, lvl) => {
    const indent = _.repeat(' ', 4 * lvl);
    const stringify = (elem) => {
      if (elem instanceof Object) {
        const result = JSON.stringify(elem, null, 8 + (4 * lvl)).replace(/["]/g, '');
        Severity: Minor
        Found in src/formats/string.js - About 1 hr to fix

          Function getPlain has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          const getPlain = (ast, masterKey = '') => {
  const result = ast.map((obj) => {
    if (obj.type === 'changed') {
      return `Property '${makeFullProperty(masterKey, obj.key)}' was updated. From '${stringify(obj.oldValue)}' to '${stringify(obj.newValue)}'`;
    }
          Severity: Minor
          Found in src/formats/plain.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if (obj.type === 'added') {
        return `${acc}\n${indent}  + ${obj.key}: ${stringify(obj.oldValue)}`;
      }
          Severity: Minor
          Found in src/formats/string.js and 1 other location - About 50 mins to fix
          src/formats/string.js on lines 21..23

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if (obj.type === 'deleted') {
        return `${acc}\n${indent}  - ${obj.key}: ${stringify(obj.oldValue)}`;
      }
          Severity: Minor
          Found in src/formats/string.js and 1 other location - About 50 mins to fix
          src/formats/string.js on lines 24..26

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if (firstObject[key] === secondObject[key]) {
        const result = {
          type: 'same',
          key,
          oldValue: firstObject[key],
          Severity: Minor
          Found in src/differ.js and 1 other location - About 45 mins to fix
          src/differ.js on lines 42..51

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if (!(key in secondObject)) {
      const result = {
        type: 'deleted',
        key,
        oldValue: firstObject[key],
          Severity: Minor
          Found in src/differ.js and 1 other location - About 45 mins to fix
          src/differ.js on lines 21..30

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this function.
          Open

              return '';
          Severity: Major
          Found in src/formats/plain.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return acc;
            Severity: Major
            Found in src/formats/string.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return `${acc}\n    ${indent}${obj.key}: {${iter(obj.children, lvl + 1)}\n    ${indent}}`;
              Severity: Major
              Found in src/formats/string.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return [...acc, result];
                Severity: Major
                Found in src/differ.js - About 30 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language