krixon/rules

View on GitHub

Showing 33 of 42 total issues

Avoid too many return statements within this method.
Open

                return $value <= $this->string;
Severity: Major
Found in src/Specification/StringMatches.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                case self::CONTAINS_ALL:   return 'contains all';
    Severity: Major
    Found in src/Operator.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return $value >= $this->string;
      Severity: Major
      Found in src/Specification/StringMatches.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $value >= $this->date;
        Severity: Major
        Found in src/Specification/DateMatches.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return $equal || $value > $this->number;
          Severity: Major
          Found in src/Specification/NumberMatches.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return null;
            Severity: Major
            Found in src/Specification/Contains.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return !$equal && ($value > $this->number);
              Severity: Major
              Found in src/Specification/NumberMatches.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            case self::MATCHES:        return 'matches';
                Severity: Major
                Found in src/Operator.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return 'UNKNOWN';
                  Severity: Major
                  Found in src/Operator.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return $value > $this->date;
                    Severity: Major
                    Found in src/Specification/DateMatches.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  case self::IN:             return 'in';
                      Severity: Major
                      Found in src/Operator.php - About 30 mins to fix

                        Function visitLogical has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function visitLogical(LogicalNode $node) : void
                            {
                                $left  = $node->left();
                                $right = $node->right();
                        
                        
                        Severity: Minor
                        Found in src/Ast/Writer.php - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function isSatisfiedBy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function isSatisfiedBy($value) : bool
                            {
                                $value = $this->extract($value);
                        
                                if (null === $value) {
                        Severity: Minor
                        Found in src/Specification/NumberMatches.php - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language