Sign upLogin

krixon/rules

View on GitHub
Star
src/Parser/DefaultParser.php

Summary

Maintainability
B
5 hrs
Test Coverage

File DefaultParser.php has 379 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

<?php

namespace Krixon\Rules\Parser;

use DateTimeImmutable;
Severity: Minor
Found in src/Parser/DefaultParser.php - About 5 hrs to fix

    DefaultParser has 28 functions (exceeds 20 allowed). Consider refactoring.
    Wontfix

    class DefaultParser implements Parser
{
    private const HINT_DATE     = 'date';
    private const HINT_TIMEZONE = 'timezone';
    Severity: Minor
    Found in src/Parser/DefaultParser.php - About 3 hrs to fix

      Method parseComparisonExpression has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function parseComparisonExpression() : Ast\Node
    {
        $left    = $this->parseIdentifier();
        $negated = false;
      Severity: Minor
      Found in src/Parser/DefaultParser.php - About 1 hr to fix

        Function parseComparisonExpression has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            private function parseComparisonExpression() : Ast\Node
    {
        $left    = $this->parseIdentifier();
        $negated = false;
        Severity: Minor
        Found in src/Parser/DefaultParser.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method parseLiteralList has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function parseLiteralList() : Ast\LiteralNodeList
    {
        $this->match(Token::LEFT_BRACKET);

        $this->next();
        Severity: Minor
        Found in src/Parser/DefaultParser.php - About 1 hr to fix

          Function parseLiteralList has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private function parseLiteralList() : Ast\LiteralNodeList
    {
        $this->match(Token::LEFT_BRACKET);

        $this->next();
          Severity: Minor
          Found in src/Parser/DefaultParser.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Wontfix

                  return new Ast\NumberNode($token->value());
          Severity: Major
          Found in src/Parser/DefaultParser.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status