Sign upLogin

krobi64/testrail

View on GitHub
Star

Showing 3 of 3 total issues

Class Client has 30 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Client

    attr_reader :request

    def initialize
Severity: Minor
Found in lib/testrail/client.rb - About 3 hrs to fix

    Method parse_payload has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def parse_payload
      result_body = JSON.parse(http_response.body)
      @success = result_body.key?('result') ? result_body.delete('result') : nil
      @payload = @success ? result_body : nil
      @error = result_body.key?('error') ? result_body.delete('error') : nil
    Severity: Minor
    Found in lib/testrail/response.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse_args has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.parse_args(*args)
      opts = args.last.instance_of?(Hash) ? args.pop : {}
      opts[:headers] = opts[:headers] ? Testrail.config.headers.merge(opts[:headers]) : Testrail.config.headers
      command = args.shift
      ids = args.empty? ? nil : args
    Severity: Minor
    Found in lib/testrail/request.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language