Sign upLogin

krygal/eebrightbox

View on GitHub
Star

Showing 3 of 3 total issues

Function split_multimac has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def split_multimac(devices):
    """
    Router can group device that uses dynamic mac addresses into a single device.

    This function splits them into separate items.
Severity: Minor
Found in eebrightbox/helpers.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _request has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def _request(self):
        """
        :returns: List or None
        """
Severity: Minor
Found in eebrightbox/router/smarthub.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_ssids has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def get_ssids(self):
        """

        :returns: List of dicts with following keys:
            - ssid
Severity: Minor
Found in eebrightbox/router/brightbox2.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language