Sign upLogin

krygal/samsung_multiroom

View on GitHub
Star
samsung_multiroom/clock/alarm.py

Summary

Maintainability
A
1 hr
Test Coverage
A
93%

Function set has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def set(self, time=None, weekdays=None, duration=None, volume=None, station_data=None, playlist=None, enabled=None):
        """
        Update speaker's configuration for this slot.

        :param time: hour/minute when to trigger the alarm in HH:MM format
Severity: Minor
Found in samsung_multiroom/clock/alarm.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function set has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def set(self, time=None, weekdays=None, duration=None, volume=None, station_data=None, playlist=None, enabled=None):
Severity: Major
Found in samsung_multiroom/clock/alarm.py - About 50 mins to fix

    There are no issues that match your filters.

    Category
    Status