Sign upLogin

kubenetworks/kubevpn

View on GitHub
Star
pkg/cp/cp.go

Summary

Maintainability
C
1 day
Test Coverage

Function recursiveTar has a Cognitive Complexity of 43 (exceeds 20 allowed). Consider refactoring.
Open

func recursiveTar(srcDir, srcFile localPath, destDir, destFile remotePath, tw *tar.Writer) error {
    matchedPaths, err := srcDir.Join(srcFile).Glob()
    if err != nil {
        return err
    }
Severity: Minor
Found in pkg/cp/cp.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method CopyOptions.untarAll has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
Open

func (o *CopyOptions) untarAll(prefix string, dest localPath, reader io.Reader) error {
    // TODO: use compression here?
    tarReader := tar.NewReader(reader)
    var linkList []tar.Header
    var genDstFilename = func(headerName string) localPath {
Severity: Minor
Found in pkg/cp/cp.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function recursiveTar has 60 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func recursiveTar(srcDir, srcFile localPath, destDir, destFile remotePath, tw *tar.Writer) error {
    matchedPaths, err := srcDir.Join(srcFile).Glob()
    if err != nil {
        return err
    }
Severity: Minor
Found in pkg/cp/cp.go - About 1 hr to fix

    Function recursiveTar has 14 return statements (exceeds 4 allowed).
    Open

    func recursiveTar(srcDir, srcFile localPath, destDir, destFile remotePath, tw *tar.Writer) error {
    matchedPaths, err := srcDir.Join(srcFile).Glob()
    if err != nil {
        return err
    }
    Severity: Major
    Found in pkg/cp/cp.go - About 1 hr to fix

      Method CopyOptions.untarAll has 52 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (o *CopyOptions) untarAll(prefix string, dest localPath, reader io.Reader) error {
    // TODO: use compression here?
    tarReader := tar.NewReader(reader)
    var linkList []tar.Header
    var genDstFilename = func(headerName string) localPath {
      Severity: Minor
      Found in pkg/cp/cp.go - About 1 hr to fix

        Method CopyOptions.untarAll has 10 return statements (exceeds 4 allowed).
        Open

        func (o *CopyOptions) untarAll(prefix string, dest localPath, reader io.Reader) error {
    // TODO: use compression here?
    tarReader := tar.NewReader(reader)
    var linkList []tar.Header
    var genDstFilename = func(headerName string) localPath {
        Severity: Major
        Found in pkg/cp/cp.go - About 1 hr to fix

          Method CopyOptions.Run has 7 return statements (exceeds 4 allowed).
          Open

          func (o *CopyOptions) Run() error {
    srcSpec, err := extractFileSpec(o.args[0])
    if err != nil {
        return err
    }
          Severity: Major
          Found in pkg/cp/cp.go - About 45 mins to fix

            There are no issues that match your filters.

            Category
            Status