Sign upLogin

kubenetworks/kubevpn

View on GitHub
Star
pkg/daemon/action/disconnect.go

Summary

Maintainability
C
1 day
Test Coverage

Method Server.Disconnect has a Cognitive Complexity of 54 (exceeds 20 allowed). Consider refactoring.
Open

func (svr *Server) Disconnect(req *rpc.DisconnectRequest, resp rpc.Daemon_DisconnectServer) error {
    defer func() {
        util.InitLoggerForServer(true)
        log.SetOutput(svr.LogFile)
        config.Debug = false
Severity: Minor
Found in pkg/daemon/action/disconnect.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Server.Disconnect has 110 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (svr *Server) Disconnect(req *rpc.DisconnectRequest, resp rpc.Daemon_DisconnectServer) error {
    defer func() {
        util.InitLoggerForServer(true)
        log.SetOutput(svr.LogFile)
        config.Debug = false
Severity: Major
Found in pkg/daemon/action/disconnect.go - About 3 hrs to fix

    Method Server.Disconnect has 6 return statements (exceeds 4 allowed).
    Open

    func (svr *Server) Disconnect(req *rpc.DisconnectRequest, resp rpc.Daemon_DisconnectServer) error {
    defer func() {
        util.InitLoggerForServer(true)
        log.SetOutput(svr.LogFile)
        config.Debug = false
    Severity: Major
    Found in pkg/daemon/action/disconnect.go - About 40 mins to fix

      Function disconnectByKubeConfig has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func disconnectByKubeConfig(ctx context.Context, svr *Server, kubeconfigBytes string, ns string, jump *rpc.SshJump) error {
      Severity: Minor
      Found in pkg/daemon/action/disconnect.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status