Sign upLogin

kubenetworks/kubevpn

View on GitHub
Star
pkg/daemon/action/proxy.go

Summary

Maintainability
C
1 day
Test Coverage

Method Server.Proxy has 121 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (svr *Server) Proxy(req *rpc.ConnectRequest, resp rpc.Daemon_ProxyServer) (e error) {
    defer func() {
        util.InitLoggerForServer(true)
        log.SetOutput(svr.LogFile)
        config.Debug = false
Severity: Major
Found in pkg/daemon/action/proxy.go - About 3 hrs to fix

    Method Server.Proxy has a Cognitive Complexity of 41 (exceeds 20 allowed). Consider refactoring.
    Open

    func (svr *Server) Proxy(req *rpc.ConnectRequest, resp rpc.Daemon_ProxyServer) (e error) {
    defer func() {
        util.InitLoggerForServer(true)
        log.SetOutput(svr.LogFile)
        config.Debug = false
    Severity: Minor
    Found in pkg/daemon/action/proxy.go - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Server.Proxy has 13 return statements (exceeds 4 allowed).
    Open

    func (svr *Server) Proxy(req *rpc.ConnectRequest, resp rpc.Daemon_ProxyServer) (e error) {
    defer func() {
        util.InitLoggerForServer(true)
        log.SetOutput(svr.LogFile)
        config.Debug = false
    Severity: Major
    Found in pkg/daemon/action/proxy.go - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                      } else if err != nil {
                    log.Errorf("Receive from disconnect failed: %v", err)
                    return err
                }
      Severity: Major
      Found in pkg/daemon/action/proxy.go - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status