Sign upLogin

kubenetworks/kubevpn

View on GitHub
Star
pkg/daemon/action/status.go

Summary

Maintainability
A
3 hrs
Test Coverage

Function gen has 67 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func gen(connect *handler.ConnectOptions, clone *handler.CloneOptions) ([]*rpc.Proxy, []*rpc.Clone, error) {
    var proxyList []*rpc.Proxy
    if connect != nil && connect.GetClientset() != nil {
        mapInterface := connect.GetClientset().CoreV1().ConfigMaps(connect.Namespace)
        configMap, err := mapInterface.Get(context.Background(), config.ConfigMapPodTrafficManager, metav1.GetOptions{})
Severity: Minor
Found in pkg/daemon/action/status.go - About 1 hr to fix

    Method Server.Status has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
    Open

    func (svr *Server) Status(ctx context.Context, req *rpc.StatusRequest) (*rpc.StatusResponse, error) {
    var list []*rpc.Status

    if len(req.ClusterIDs) != 0 {
        for _, clusterID := range req.ClusterIDs {
    Severity: Minor
    Found in pkg/daemon/action/status.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function gen has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
    Open

    func gen(connect *handler.ConnectOptions, clone *handler.CloneOptions) ([]*rpc.Proxy, []*rpc.Clone, error) {
    var proxyList []*rpc.Proxy
    if connect != nil && connect.GetClientset() != nil {
        mapInterface := connect.GetClientset().CoreV1().ConfigMaps(connect.Namespace)
        configMap, err := mapInterface.Get(context.Background(), config.ConfigMapPodTrafficManager, metav1.GetOptions{})
    Severity: Minor
    Found in pkg/daemon/action/status.go - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status