Sign upLogin

kubenetworks/kubevpn

View on GitHub
Star
pkg/daemon/client.go

Summary

Maintainability
A
3 hrs
Test Coverage

Function GetClient has 52 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func GetClient(isSudo bool) (cli rpc.DaemonClient) {
    sockPath := config.GetSockPath(isSudo)
    if _, err := os.Stat(sockPath); errors.Is(err, os.ErrNotExist) {
        return nil
    }
Severity: Minor
Found in pkg/daemon/client.go - About 1 hr to fix

    Function GetClient has 9 return statements (exceeds 4 allowed).
    Open

    func GetClient(isSudo bool) (cli rpc.DaemonClient) {
    sockPath := config.GetSockPath(isSudo)
    if _, err := os.Stat(sockPath); errors.Is(err, os.ErrNotExist) {
        return nil
    }
    Severity: Major
    Found in pkg/daemon/client.go - About 55 mins to fix

      Function GetClientWithoutCache has 5 return statements (exceeds 4 allowed).
      Open

      func GetClientWithoutCache(ctx context.Context, isSudo bool) (cli rpc.DaemonClient, conn *grpc.ClientConn, err error) {
    sockPath := config.GetSockPath(isSudo)
    _, err = os.Stat(sockPath)
    if errors.Is(err, os.ErrNotExist) {
        return
      Severity: Major
      Found in pkg/daemon/client.go - About 35 mins to fix

        Function runDaemon has 5 return statements (exceeds 4 allowed).
        Open

        func runDaemon(ctx context.Context, exe string, isSudo bool) error {
    cli := GetClient(isSudo)
    if cli != nil {
        return nil
    }
        Severity: Major
        Found in pkg/daemon/client.go - About 35 mins to fix

          Function GetClient has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
          Open

          func GetClient(isSudo bool) (cli rpc.DaemonClient) {
    sockPath := config.GetSockPath(isSudo)
    if _, err := os.Stat(sockPath); errors.Is(err, os.ErrNotExist) {
        return nil
    }
          Severity: Minor
          Found in pkg/daemon/client.go - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status